Conversation
…8583) `@formatjs/unplugin` with `ast: true` compiles `defineMessages()` output into AST arrays at build time, so `.defaultMessage` returns `{type, value}` objects instead of strings. `CLERK_ERROR_MESSAGES` was passing these objects directly to `<h1>`/`<p>`/`<button>` in `ErrorPage`, crashing React with "Objects are not valid as a React child". This replaces the `.defaultMessage` references with hardcoded English strings, matching the existing pattern in `main.tsx:13-18` (`TOP_LEVEL_ERROR_MESSAGES`) which also sits outside `IntlWrapper` and uses the same approach. ### Change type - [x] `bugfix` ### Test plan 1. Deploy and trigger the Clerk error boundary (e.g. block Clerk's domain) 2. Verify the error page renders correctly with "Unable to connect" header ### Release notes - Fix crash when Clerk authentication service is unavailable ### Code changes | Section | LOC change | | ------- | ---------- | | Apps | +4 / -3 |
) In order to prevent `ReferenceError: Can't find variable: OffscreenCanvas` in browsers without `OffscreenCanvas` support (older Safari, some iOS — 2.2K events / 344 users in 90d), this PR adds an early return in `preloadAlphaData`. The degradation is already graceful — when alpha data isn't loaded, `isImagePointTransparent` returns `false` (treats all pixels as opaque), so no further changes are needed. ### Change type - [x] `bugfix` ### Test plan - Open tldraw in a browser without `OffscreenCanvas` support (e.g. older Safari/iOS) - Verify no console errors related to `OffscreenCanvas` - Verify image shapes still work (clicking transparent areas selects the shape, which is the expected fallback) ### Release notes - Fix crash in browsers without `OffscreenCanvas` support (e.g. older Safari) ### Code changes | Section | LOC change | | --------- | ---------- | | Core code | +1 / -0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )