Conversation
Updates the next section of the releases and adds a section to the top of the releases page explaining our different types of releases
In order to make `GeoShapeUtil.configure()` actually ignore colliding `customGeoTypes` keys, this PR strips the colliding entries out of the options before delegating to `super.configure()`. Follow-up to review feedback on #8705. Previously, the dev-mode warning said the colliding key would be ignored, but only the schema registration was skipped. The colliding entry still landed in `this.options.customGeoTypes` and was consulted at runtime in three places that silently changed built-in behavior: - `toolStates/Pointing.ts` — used the user's `defaultSize` for built-in geos when drag-creating with no drag. - `DefaultStylePanelContent.tsx` — filtered the built-in style panel item out (`STYLES.geo.filter((item) => !customGeoTypes?.[item.value])`) and replaced its icon. - `GeoShapeUtil.onDoubleClick` — ran the user's handler on the built-in geo. Now the warning matches reality: colliding entries are dropped from the options object that's stored on the util. ### Change type - [x] `bugfix` ### Test plan 1. Run the new tests in `GeoShapeUtil.test.tsx` (`describe('GeoShapeUtil.configure with customGeoTypes')`). - [x] Unit tests ### Release notes - Fix `GeoShapeUtil.configure()` so colliding `customGeoTypes` keys are actually ignored, instead of leaking through to the tool's default size, the style panel, and the double-click handler. ### Code changes | Section | LOC change | | --------- | ---------- | | Core code | +11 / -5 | | Tests | +51 / -0 | Made with [Cursor](https://cursor.com)
### Change type - [ ] `bugfix` - [ ] `improvement` - [ ] `feature` - [ ] `api` - [x] `other`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )