[pull] main from tldraw:main#548
Merged
Merged
Conversation
In order to catch silent failures in important pipelines (publishing SDK packages, publishing VS Code extensions, deploying the MCP app, daily preview cleanup), this PR adds a Discord notification step to each so failures show up in the same channel where dotcom deploy failures are already posted. A new composite action at `.github/actions/discord-fail-notify` posts a brief message — `@Engineering ❌ <workflow> failed on <ref>: <run-url>` — to `DISCORD_DEPLOY_WEBHOOK_URL` when a job fails. It guards against an empty webhook (logs a warning and skips, so forks and misconfigured envs don't run misleading curl commands) and uses `curl -f` so a bad webhook surfaces as a failed step rather than a silent 4xx. Workflows now wired up: - `bump-versions`, `publish-canary`, `publish-patch`, `publish-new`, `publish-manual`, `publish-branch` — `npm deploy` env - `publish-editor-extensions`, `publish-vscode-extension` — `vsce publish` env (still needs `DISCORD_DEPLOY_WEBHOOK_URL` added to that env in repo settings) - `deploy-mcp-app` — `deploy-production` env - `prune-preview-deploys` — `deploy-staging` env `trigger-production-build` and `publish-templates` have no `environment:` block, so they can't resolve the env-scoped secret; left as-is for now. The role mention `<@&1414904550917144586>` is the same `@Engineering` role already used by `Discord.AT_TEAM_MENTION` in `deploy-dotcom`, `deploy-bemo`, and `deploy-analytics`. ### Change type - [x] `other` ### Test plan Can't trigger a real workflow failure without merging. Verified by: 1. Walking through historical failure `publish-canary` run 25431962448 (S3 `AccessDenied` during `uploadStaticAssets`) — with the new step in place, the `if: failure()` step would have fired after the failing publish step. 2. Confirmed `jq` is preinstalled on the runner class (already used in `deploy-dotcom.yml`). 3. Confirmed the role mention matches the `@Engineering` role used by existing dotcom failure pings. ### Code changes | Section | LOC change | | --------------- | ---------- | | Config/tooling | +87 / -0 |
Bumps `@rocicorp/zero` from 1.4.0 to 1.5.0 across the dotcom packages. ### Change type - [x] `other` ### Test plan 1. CI passes. 2. Verify zero-cache + sync-worker still come up locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )