[pull] main from tldraw:main#552
Merged
Merged
Conversation
…Rs (#8746) The `prune-preview-deploys` workflow already tears down preview workers, Supabase branches, fly.io zero-cache apps, and Zero litestream R2 backups, but it didn't touch `dotcom-deploy-assets-cache` — the R2 bucket where `coalesceWithPreviousAssets` (`internal/scripts/deploy-dotcom.ts:957`) writes a tarball per deploy. Closed PRs were leaving `pr-<n>/` folders behind forever. This PR adds a fifth prune pass over that bucket, reusing the existing closed-for-2-days filter via `processItems`. Since both R2 prunes were near-duplicates, I refactored them into shared `listR2PrPrefixes` / `deleteR2Prefix` helpers parameterized by an `R2BucketRef` ({client, bucket, label}). Adding more buckets in future is one literal each. Net diff is +43/-80. `staging/` and `production/` prefixes are intentionally untouched — they're required by `coalesceWithPreviousAssets` for rollback safety. Also broadens the fly.io app regex from `^pr-\d+-zero-cache$` to `^pr-\d+-zero-(cache|rm|vs)$` so preview `zero-rm` and `zero-vs` apps get torn down alongside `zero-cache`. Without this, the leftover apps kept writing new litestream backups into already-pruned `pr-<n>/` prefixes in the Zero R2 bucket, so the same prefix kept reappearing in nightly runs. Closes #8745. ### Change type - [x] `other` ### Test plan - Workflow runs daily on cron; will be exercised on the next scheduled run after merge. Reuses the same `R2_ACCESS_KEY_ID` / `R2_ACCESS_KEY_SECRET` secrets the dotcom deploy job already uses for this bucket, so no new secrets needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )