[pull] main from tldraw:main#559
Merged
Merged
Conversation
In order to make the page menu fit its rows without extra trailing space and surface the max-pages limit in the UI, this PR auto-fits the list to the row stack, lowers the resize minimum to one row, refactors the resize handle into a flush 1px divider with a separate hit-test area, and always renders the create button (disabled with a "Maximum pages reached" tooltip when the page count hits `editor.options.maxPages`). Closes #8862. ### Change type - [x] `bugfix` ### Test plan 1. Open the page menu with multiple pages and confirm the list fits the row stack with no trailing space. 2. Drag the resize handle upward and confirm it stops at a one-row height. 3. Drag the resize handle downward, then double-click it and confirm the list resets to the auto-fit height. 4. Create pages up to `maxPages` and confirm the create button stays visible, becomes disabled, drops its `+` icon, and shows the "Maximum pages reached" tooltip. - [ ] Unit tests - [x] End to end tests ### Release notes - Fix the page menu list height so it no longer leaves extra trailing space when opened, resized, or reset. - Keep the create-page button visible when the page limit is reached, disabled with a "Maximum pages reached" tooltip. ### API changes - Added `'page-menu.max-pages-reached'` to `TLUiTranslationKey` and `DEFAULT_TRANSLATION`. ### Code changes | Section | LOC change | | --------------- | ---------- | | Core code | +53 / -33 | | Tests | +54 / -0 | | Automated files | +1 / -1 |
In order to avoid leaving the user stuck on a file they no longer have access to, this PR makes `handleLeaveGroup` mirror `handleDeleteGroup` in `GroupSettingsDialog`: if the user is viewing a file owned by the group they just left, navigate them to `/`. Previously the sidebar updated but the file stayed open until the next server-side access check failed with `FORBIDDEN`. Closes #8340 ### Change type - [x] `bugfix` ### Test plan 1. Be a member of a group that owns files. 2. Open a file belonging to that group. 3. Open group settings and leave the group. 4. You should be redirected away from the file instead of remaining on it. ### Release notes - Fix: redirect away from a group file when leaving the group.
In order to drop the Context7 docs integration from the repo, this PR removes the `context7.json` registration file (which pointed the repo at context7.com with a public key) and deletes the two `mcp__Context7__*` permission entries from `.claude/settings.json`. These were the only references to Context7 in the repository. ### Change type - [x] `other` ### Test plan - No user-facing behavior; nothing to test manually. ### Release notes - Omit — internal tooling change with no user-facing impact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )