[pull] main from tldraw:main#610
Merged
Merged
Conversation
In order to speed up the SDK publish workflow, this PR uploads static assets to the CDN with bounded concurrency instead of one file at a time. Previously `uploadStaticAssets` walked the assets tree and `await`ed each R2 `PutObjectCommand` sequentially, so every upload waited for the previous one to finish even though they're fully independent. With many asset files this dominated the publish step. The upload now collects every file up front and processes them through a small worker pool (16 concurrent uploads), so wall time drops to roughly the previous time divided by the concurrency limit while staying well-behaved against R2. ### Change type - [x] `improvement` ### Test plan This runs only during the package publish workflow (`internal/scripts/lib/upload-static-assets.ts`) and is exercised the next time SDK packages are published. No behavior changes beyond upload ordering and concurrency. ### Code changes | Section | LOC change | | -------------- | ---------- | | Config/tooling | +33 / -11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )