[pull] main from tldraw:main#620
Merged
Merged
Conversation
…9416) In order to avoid a redundant group header when the sidebar file list only has one time-based group (e.g. only "Today", or only "Older"), this PR hides the solo section's title via CSS. Each section renders as a `sidebarFileSectionWrapper` element directly inside the file list container, and empty groups render as `null` rather than empty nodes. So "only one section is present" is exactly `:only-child`, and a single CSS rule hides that section's header. As soon as a second section appears, all headers return. Closes #9412 ### Change type - [x] `improvement` ### Test plan 1. Open tldraw.com with an account whose files all fall into a single time group (e.g. all created today). 2. Confirm the sidebar shows the file list with no "Today" header. 3. Create or open an older file so a second group appears. 4. Confirm both group headers ("Today", "Older", etc.) are now shown. ### Release notes - Hide the sidebar file-group header when only one group is present. ### Code changes | Section | LOC change | | ------- | ---------- | | Apps | +6 / -0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )