Skip to content

Commit 0e8fbd6

Browse files
authored
chore: Switch from Lerna and Yarn 1 to NPM (mobxjs#4646)
* Replace lerna with npm / yarn * Replace yarn 1 with npm * Keep mobx-undecorate CLI diff focused * Add changeset for mobx-undecorate CLI fix
1 parent 1cd6a34 commit 0e8fbd6

17 files changed

Lines changed: 50836 additions & 28860 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"mobx-undecorate": patch
3+
---
4+
5+
Fix CLI resolution of the bundled jscodeshift binary when dependencies are hoisted by npm workspaces.

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
- [ ] Added/updated unit tests
1616
- [ ] Updated `/docs`. For new functionality, at least `API.md` should be updated
17-
- [ ] Verified that there is no significant performance drop (`yarn mobx test:performance`)
17+
- [ ] Verified that there is no significant performance drop (`npm -w mobx run test:performance`)
1818

1919
<!--
2020
Feel free to ask help with any of these boxes!

.github/workflows/build_and_test.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,25 +21,25 @@ jobs:
2121
node-version: 24
2222

2323
- name: Install Dependencies
24-
run: yarn --frozen-lockfile --ignore-scripts
24+
run: npm ci --ignore-scripts
2525

2626
- name: Lint
27-
run: yarn lint
27+
run: npm run lint
2828

2929
- name: Build check
30-
run: yarn lerna run build:check
30+
run: npm run build:check
3131

3232
- name: Build packages
33-
run: yarn lerna run build:test
33+
run: npm run build:test
3434

3535
- name: Test
36-
run: yarn test -i
36+
run: npm test -- -i
3737

3838
- name: Test size
39-
run: yarn lerna run test:size
39+
run: npm run test:size
4040

4141
- name: Test flow
42-
run: yarn mobx test:flow
42+
run: npm -w mobx run test:flow
4343

4444
- name: Test performance
45-
run: yarn mobx test:performance
45+
run: npm -w mobx run test:performance

.github/workflows/coveralls.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ jobs:
1919
node-version: 24
2020

2121
- name: Install Dependencies
22-
run: yarn --frozen-lockfile --ignore-scripts
22+
run: npm ci --ignore-scripts
2323

2424
- name: Build packages
25-
run: yarn lerna run build:test
25+
run: npm run build:test
2626

2727
# - name: Run Coverage
28-
# run: yarn coverage
28+
# run: npm run coverage
2929

3030
# - name: Upload to coveralls
3131
# uses: coverallsapp/github-action@v2.3.6

.github/workflows/release.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@ jobs:
3131
registry-url: https://registry.npmjs.org
3232

3333
- name: Install Dependencies
34-
run: yarn
34+
run: npm ci --ignore-scripts
3535

3636
- name: Build packages
37-
run: yarn lerna run build
37+
run: npm run build
3838

3939
- name: Create Release Pull Request or Publish to npm
4040
id: changesets
@@ -44,4 +44,3 @@ jobs:
4444
publish: npm run release
4545
env:
4646
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
47-

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,5 @@ dist/
1313
*.iml
1414
*.ipr
1515
*.iws
16-
yarn-error.log
1716
build/
1817
.DS_Store

CONTRIBUTING.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,12 @@ For a small bug fix change (less than 20 lines of code changed), feel free to op
3333

3434
#### Getting things running
3535

36+
Use Node.js 24, matching CI. The npm version bundled with Node is sufficient.
37+
3638
```
3739
git clone git@github.com:mobxjs/mobx.git
3840
cd mobx
39-
yarn install
40-
yarn lerna run build
41-
yarn test
41+
npm install
42+
npm run build
43+
npm test
4244
```
43-

lerna.json

Lines changed: 0 additions & 6 deletions
This file was deleted.

0 commit comments

Comments
 (0)