Commit 7fd9334
Fix Stage 3 decorator inheritance (mobxjs#4661)
* fix: @computed override with super no longer causes cycle detection
Fixes mobxjs#4639 — when a child class @computed getter references super.value,
MobX no longer throws 'Cycle detected in computation'.
Architecture:
- Common case (no inheritance): factories stored in lazyComputedKeys_
(identical to main branch), materialized on first read
- Inheritance case: parent entries moved to computedGetterEntries_ (Map
keyed by getter function), child entries in computedEntries_
- readComputed_ method checks derivation === expectedGet to detect
super calls and routes to the correct ComputedValue
- Prototype chain traversal + __mobx_get finds parent getter without
per-instance WeakMap overhead
- getObservablePropValue_ kept clean (no expectedGet) for makeObservable
Performance vs main branch (50k instances × 10 computed getters):
Heap: +0.5%
Construct: -7.8%
First-read: -4.2%
Re-read: +6.6% (inherent cost of derivation check for super support)
* Revert "fix: @computed override with super no longer causes cycle detection"
This reverts commit a559575.
* Fix Stage 3 computed inheritance
* Simplify inheritance tests
* Document unsupported (for now) test
* Reorg tests
---------
Co-authored-by: Gorbachev Egor <7gorbachevm@gmail.com>
Co-authored-by: Сергей Волков <ser.volkov@vk.team>1 parent f26830a commit 7fd9334
4 files changed
Lines changed: 453 additions & 17 deletions
File tree
- .changeset
- docs
- packages/mobx
- __tests__/decorators_20223
- src/types
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
12 | 15 | | |
13 | 16 | | |
14 | | - | |
| 17 | + | |
15 | 18 | | |
16 | 19 | | |
17 | 20 | | |
| |||
25 | 28 | | |
26 | 29 | | |
27 | 30 | | |
| 31 | + | |
28 | 32 | | |
29 | 33 | | |
30 | 34 | | |
31 | 35 | | |
32 | | - | |
| 36 | + | |
33 | 37 | | |
34 | 38 | | |
35 | 39 | | |
| 40 | + | |
36 | 41 | | |
37 | 42 | | |
38 | 43 | | |
| |||
50 | 55 | | |
51 | 56 | | |
52 | 57 | | |
| 58 | + | |
53 | 59 | | |
54 | 60 | | |
55 | | - | |
| 61 | + | |
56 | 62 | | |
57 | 63 | | |
58 | 64 | | |
59 | 65 | | |
| 66 | + | |
60 | 67 | | |
61 | 68 | | |
62 | 69 | | |
| |||
65 | 72 | | |
66 | 73 | | |
67 | 74 | | |
| 75 | + | |
68 | 76 | | |
69 | 77 | | |
70 | 78 | | |
71 | 79 | | |
72 | 80 | | |
73 | 81 | | |
| 82 | + | |
74 | 83 | | |
75 | 84 | | |
76 | 85 | | |
77 | 86 | | |
78 | 87 | | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
79 | 142 | | |
80 | 143 | | |
81 | 144 | | |
| |||
0 commit comments