[pull] main from mobxjs:main#51
Merged
Merged
Conversation
* Replace lerna with npm / yarn * Replace yarn 1 with npm * Keep mobx-undecorate CLI diff focused * Add changeset for mobx-undecorate CLI fix
* fix(mobx): make 2022.3 @computed decorator lazy ComputedValue is now created on first read of the decorated getter instead of eagerly during instance construction, so getters that are never accessed on a given instance no longer allocate a ComputedValue. Closes #4616 * perf(mobx): collapse lazy-computed read to one map lookup Address review on #4639: - getObservablePropValue_ / setObservablePropValue_ / getAtom now do values_.get(key) ?? materializeLazyComputed_(key), so the hot path (computed already materialised, plain observable, or non-lazy class) is a single Map lookup instead of two. - materializeLazyComputed_ returns the freshly-built ComputedValue (or undefined when the key isn't lazy) so callers don't have to look it up again. Drops the unused boolean return. * test(mobx): add @computed decorator perf benchmark Adds a standalone perf benchmark for the lazy `@computed` decorator (#4639): 50k instances × 10 getters with 1 read/instance — the realistic "wide class, sparse access" shape from #4616. Run with `yarn perf-decorator` (requires a prior `yarn build`). * chore(changeset): mark lazy @computed decorator as feat/minor Per maintainer review on #4639: the lazy `@computed` decorator is a perf improvement worth a minor bump rather than a patch. Reframes the entry as `feat:` and notes the construction heap / time savings measured by the benchmark added in the previous commit. --------- Co-authored-by: Michel Weststrate <mweststrate@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )