[pull] main from mobxjs:main#55
Merged
Merged
Conversation
Bumps [changesets/action](https://github.com/changesets/action) from 1.8.0 to 1.9.0. - [Release notes](https://github.com/changesets/action/releases) - [Changelog](https://github.com/changesets/action/blob/main/CHANGELOG.md) - [Commits](changesets/action@v1.8.0...v1.9.0) --- updated-dependencies: - dependency-name: changesets/action dependency-version: 1.9.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: @computed override with super no longer causes cycle detection Fixes #4639 — when a child class @computed getter references super.value, MobX no longer throws 'Cycle detected in computation'. Architecture: - Common case (no inheritance): factories stored in lazyComputedKeys_ (identical to main branch), materialized on first read - Inheritance case: parent entries moved to computedGetterEntries_ (Map keyed by getter function), child entries in computedEntries_ - readComputed_ method checks derivation === expectedGet to detect super calls and routes to the correct ComputedValue - Prototype chain traversal + __mobx_get finds parent getter without per-instance WeakMap overhead - getObservablePropValue_ kept clean (no expectedGet) for makeObservable Performance vs main branch (50k instances × 10 computed getters): Heap: +0.5% Construct: -7.8% First-read: -4.2% Re-read: +6.6% (inherent cost of derivation check for super support) * Revert "fix: @computed override with super no longer causes cycle detection" This reverts commit a559575. * Fix Stage 3 computed inheritance * Simplify inheritance tests * Document unsupported (for now) test * Reorg tests --------- Co-authored-by: Gorbachev Egor <7gorbachevm@gmail.com> Co-authored-by: Сергей Волков <ser.volkov@vk.team>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )