Conversation
* S2 SelectBox initial implementation * Added tests and fixed linting * updated tests to remove styles * selectbox refactor and tests refactor * stories changes and various edits * replaced aria components with a gridlist * fixed borders and redid stories/tests * removed extraneous overrides and isEmphasized prop * lint and removed XS * test-utils-internal swap * test-utils-internal swap * swapped useId library * swapped to listbox * added additional props and removed s2 checkbox * revised tests, added additional props, swapped to UI checkmark to avoid accessibility issues * adjusted illustration size * removed the sizing and fixed various alignment issues. replaced checkbox behavior * fixed group disabled checkbox issue * pruned styles * fixed label overflow, description still remaining * moved selectbox into same file, reworked grid, addressed various gh comments * s2(SelectBoxGroup): center label in horizontal layout when only label is present * s2(SelectBoxGroup): support [DEFAULT_SLOT] as label styles for text-only children * removed extra story and count check --------- Co-authored-by: Daniel Pandyan <dpadbe@work.local>
* initialize gridlist section and headers * add test for gridlist sections * add tests, cleanup * fix lint * remove spacing * merge props, useLabels * follow-up * fix aria-rowindex * remove aria-rolindex for headers * pass state and ref to hook * fix lint
…7794) * add more components to s2 example * add s2 next.js example to verdaccio build * add to CI comment * enable verdaccio build on branch * yarn fixes * fix warnings/errors * next upgrade * typescript routing fix * add to CI * add TreeView and fix types * fix VERDACCIO env variable during build * add Provider * add 'use client' to app/layout.tsx * move provider into client * add back main filters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )