Conversation
…s virtual focus (#8862) * exporting contexts for quarry * refactor autocomplete hook so it detects if it is attached to a filterable collection and if said collection supports virtual focus * initial attempt to get rid of Dialog from S2 Popover * fix tests * add inner div with overflow so that popover arrow shows up * fix items overflowing when partially scrolled into view see https://github.com/adobe/react-spectrum/pull/7672/files * update Popover so it accepts more values in styles instead * fix lint * export colorSchemeContext * clean up extra comment * fix chromatic * review comments * fix calc * substitute custom event in favor of collection tabindex check collection should only have a tab index if it isnt using virtual focus * update width calculations turns out the border of the popover shouldnt be included in the total width calculation, it is considered outside of the popover so no need to adjust. The border will be removed in favor of a box shadow to conform with update designs later * forgot to remove commented out code * move popover styling to user provided inner div as per discussion with team, if someone wants to modify their popover internals, they are expected to add a inner wrapping div themselves and turn off padding like custom dialog. * forgot to bring back styles --------- Co-authored-by: Robert Snow <snowystinger@gmail.com>
* fix: gridlist section accessibility updates pt2 * remove unused import
* readd placeholder support to S2 components * progress * adding tests * fix combobox placeholder warning * apply specific color to placeholders * getting rid of unneeded warnings and adding missing placeholders * fix tests * review comments * fix tests * remove placeholder warning * add docs for placeholder and fix docs control for it and other string type props * remove unused tests and fix lint * sigh lint * review comments * update new combobox example * Add more placeholders in docs --------- Co-authored-by: Devon Govett <devongovett@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )