Conversation
* table inline editing * remove extra exports * Add extra controls for different interactions, mobile, inline save, invalid state, click off * fix lint * Add fake saving logic * use better color and fix flex grow * add back hiding logic * simplify fake save logic * set boundary element of the table, design updates * Add picker, restore focus to cell when trigger is hidden, converge implementation to make generic, fix density, individual cell saving state, use touch detection for showing all the time * fix lint and small screen rendering * Change editable cell hover color when row is hovered * invert hover color for non-selection * use a pending action button and change background cell color for hover * fix lint * fix density, pending is disabled, some of cell sizing * Add bulk edit bar * fix lint * add "More" actions and remove actionbar bulk actions * fix rendering * Add other components so we know if there's anything else * simplify code and example * add comments and fix types * Make picker nice * fix lint * Implement our actual component and start tests * add default slot so that people can add other buttons to the row * fix lint * add tests * fix lint * review updates * fix tab behaviour * add tab tests
…ListBoxItem` (#8908) * add ComboBox Story for ListBoxItem with aria-label This can be used to check whether the screen-reader announcement for option selections reads the correct label for each option, especially on mac, where there is a special codepath for this. * fix `CollectionBuilder` to handle `aria-label` correctly This commit ensures the aria-label prop from the ListItem is read into the corresponding attribute ElementNode * only add key if it exists --------- Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Robert Snow <snowystinger@gmail.com>
* docs: Make component card heights match * Fix Safari 🤮
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )