Conversation
* feat: add new maxSpace option * feat: add new private margin property * feat: take maxSpace into account when computing horizontal spacing & compute margin * example use of GridList maxSpace * chore: rename maxSpace into maxHorizontalSpace * feat: add controls to the VirtualizedGridListGrid story
* add addSelectedKeys and removeSelectedKeys methods to useListData * create tests for new methods to useListData * keep same pattern for reassigning selection variable * rename methods * keep original selection value * remove validation for keys * adding some additional test cases --------- Co-authored-by: rbuzatto <rafael.buzatto@energage.com> Co-authored-by: Daniel Lu <dl1644@gmail.com>
* wip * bump actions * use system time zone
* useDrag: clearData is onDragStart before writeToDataTransfer * optional chaining to avoid test failures without mock
* Add typescript build support for s2 * rename package.json * remove pm details * update webpack config * fix typescript * add empty yarn lock --------- Co-authored-by: Cezar Sirbu <csirbu@adobe.com> Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com>
…to consideration (#8642) * fix: check for element visibility should take react aria attribute into consideration * remove log * deleted too much
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )