Skip to content

Commit 49b1cea

Browse files
pull[bot]pull[bot]
committed
[flags] Clean up enableHiddenSubtreeInsertionEffectCleanup (facebook#35918)
Been enabled in stable for quite a while, also rolled out at Meta. DiffTrain build for [e0cc720](facebook@e0cc720)
1 parent 2bd5456 commit 49b1cea

36 files changed

Lines changed: 159 additions & 208 deletions

‎compiled/facebook-www/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
b4a8d298450fd1fd274445fe8554e5fc18c5e12c
1+
e0cc7202e14418b453c69c4f06dc00c64151f202

‎compiled/facebook-www/REVISION_TRANSFORMS‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
b4a8d298450fd1fd274445fe8554e5fc18c5e12c
1+
e0cc7202e14418b453c69c4f06dc00c64151f202

‎compiled/facebook-www/React-dev.classic.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1482,7 +1482,7 @@ __DEV__ &&
14821482
exports.useTransition = function () {
14831483
return resolveDispatcher().useTransition();
14841484
};
1485-
exports.version = "19.3.0-www-classic-b4a8d298-20260226";
1485+
exports.version = "19.3.0-www-classic-e0cc7202-20260227";
14861486
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
14871487
"function" ===
14881488
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-dev.modern.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1482,7 +1482,7 @@ __DEV__ &&
14821482
exports.useTransition = function () {
14831483
return resolveDispatcher().useTransition();
14841484
};
1485-
exports.version = "19.3.0-www-modern-b4a8d298-20260226";
1485+
exports.version = "19.3.0-www-modern-e0cc7202-20260227";
14861486
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
14871487
"function" ===
14881488
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-prod.classic.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -610,4 +610,4 @@ exports.useSyncExternalStore = function (
610610
exports.useTransition = function () {
611611
return ReactSharedInternals.H.useTransition();
612612
};
613-
exports.version = "19.3.0-www-classic-b4a8d298-20260226";
613+
exports.version = "19.3.0-www-classic-e0cc7202-20260227";

‎compiled/facebook-www/React-prod.modern.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -610,4 +610,4 @@ exports.useSyncExternalStore = function (
610610
exports.useTransition = function () {
611611
return ReactSharedInternals.H.useTransition();
612612
};
613-
exports.version = "19.3.0-www-modern-b4a8d298-20260226";
613+
exports.version = "19.3.0-www-modern-e0cc7202-20260227";

‎compiled/facebook-www/React-profiling.classic.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -614,7 +614,7 @@ exports.useSyncExternalStore = function (
614614
exports.useTransition = function () {
615615
return ReactSharedInternals.H.useTransition();
616616
};
617-
exports.version = "19.3.0-www-classic-b4a8d298-20260226";
617+
exports.version = "19.3.0-www-classic-e0cc7202-20260227";
618618
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
619619
"function" ===
620620
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-profiling.modern.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -614,7 +614,7 @@ exports.useSyncExternalStore = function (
614614
exports.useTransition = function () {
615615
return ReactSharedInternals.H.useTransition();
616616
};
617-
exports.version = "19.3.0-www-modern-b4a8d298-20260226";
617+
exports.version = "19.3.0-www-modern-e0cc7202-20260227";
618618
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
619619
"function" ===
620620
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/ReactART-dev.classic.js‎

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12798,13 +12798,11 @@ __DEV__ &&
1279812798
case 11:
1279912799
case 14:
1280012800
case 15:
12801-
(!enableHiddenSubtreeInsertionEffectCleanup &&
12802-
offscreenSubtreeWasHidden) ||
12803-
commitHookEffectListUnmount(
12804-
Insertion,
12805-
deletedFiber,
12806-
nearestMountedAncestor
12807-
);
12801+
commitHookEffectListUnmount(
12802+
Insertion,
12803+
deletedFiber,
12804+
nearestMountedAncestor
12805+
);
1280812806
offscreenSubtreeWasHidden ||
1280912807
commitHookLayoutUnmountEffects(
1281012808
deletedFiber,
@@ -18158,8 +18156,6 @@ __DEV__ &&
1815818156
dynamicFeatureFlags.disableSchedulerTimeoutInWorkLoop,
1815918157
enableEffectEventMutationPhase =
1816018158
dynamicFeatureFlags.enableEffectEventMutationPhase,
18161-
enableHiddenSubtreeInsertionEffectCleanup =
18162-
dynamicFeatureFlags.enableHiddenSubtreeInsertionEffectCleanup,
1816318159
enableInfiniteRenderLoopDetection =
1816418160
dynamicFeatureFlags.enableInfiniteRenderLoopDetection,
1816518161
enableNoCloningMemoCache = dynamicFeatureFlags.enableNoCloningMemoCache,
@@ -20404,10 +20400,10 @@ __DEV__ &&
2040420400
(function () {
2040520401
var internals = {
2040620402
bundleType: 1,
20407-
version: "19.3.0-www-classic-b4a8d298-20260226",
20403+
version: "19.3.0-www-classic-e0cc7202-20260227",
2040820404
rendererPackageName: "react-art",
2040920405
currentDispatcherRef: ReactSharedInternals,
20410-
reconcilerVersion: "19.3.0-www-classic-b4a8d298-20260226"
20406+
reconcilerVersion: "19.3.0-www-classic-e0cc7202-20260227"
2041120407
};
2041220408
internals.overrideHookState = overrideHookState;
2041320409
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -20442,7 +20438,7 @@ __DEV__ &&
2044220438
exports.Shape = Shape;
2044320439
exports.Surface = Surface;
2044420440
exports.Text = Text;
20445-
exports.version = "19.3.0-www-classic-b4a8d298-20260226";
20441+
exports.version = "19.3.0-www-classic-e0cc7202-20260227";
2044620442
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
2044720443
"function" ===
2044820444
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/ReactART-dev.modern.js‎

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12616,13 +12616,11 @@ __DEV__ &&
1261612616
case 11:
1261712617
case 14:
1261812618
case 15:
12619-
(!enableHiddenSubtreeInsertionEffectCleanup &&
12620-
offscreenSubtreeWasHidden) ||
12621-
commitHookEffectListUnmount(
12622-
Insertion,
12623-
deletedFiber,
12624-
nearestMountedAncestor
12625-
);
12619+
commitHookEffectListUnmount(
12620+
Insertion,
12621+
deletedFiber,
12622+
nearestMountedAncestor
12623+
);
1262612624
offscreenSubtreeWasHidden ||
1262712625
commitHookLayoutUnmountEffects(
1262812626
deletedFiber,
@@ -17934,8 +17932,6 @@ __DEV__ &&
1793417932
dynamicFeatureFlags.disableSchedulerTimeoutInWorkLoop,
1793517933
enableEffectEventMutationPhase =
1793617934
dynamicFeatureFlags.enableEffectEventMutationPhase,
17937-
enableHiddenSubtreeInsertionEffectCleanup =
17938-
dynamicFeatureFlags.enableHiddenSubtreeInsertionEffectCleanup,
1793917935
enableInfiniteRenderLoopDetection =
1794017936
dynamicFeatureFlags.enableInfiniteRenderLoopDetection,
1794117937
enableNoCloningMemoCache = dynamicFeatureFlags.enableNoCloningMemoCache,
@@ -20175,10 +20171,10 @@ __DEV__ &&
2017520171
(function () {
2017620172
var internals = {
2017720173
bundleType: 1,
20178-
version: "19.3.0-www-modern-b4a8d298-20260226",
20174+
version: "19.3.0-www-modern-e0cc7202-20260227",
2017920175
rendererPackageName: "react-art",
2018020176
currentDispatcherRef: ReactSharedInternals,
20181-
reconcilerVersion: "19.3.0-www-modern-b4a8d298-20260226"
20177+
reconcilerVersion: "19.3.0-www-modern-e0cc7202-20260227"
2018220178
};
2018320179
internals.overrideHookState = overrideHookState;
2018420180
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -20213,7 +20209,7 @@ __DEV__ &&
2021320209
exports.Shape = Shape;
2021420210
exports.Surface = Surface;
2021520211
exports.Text = Text;
20216-
exports.version = "19.3.0-www-modern-b4a8d298-20260226";
20212+
exports.version = "19.3.0-www-modern-e0cc7202-20260227";
2021720213
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
2021820214
"function" ===
2021920215
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)