Skip to content

Commit a5595f4

Browse files
pull[bot]pull[bot]
committed
[DevTools] chore: extract pure functions from fiber/renderer.js (facebook#35924)
I am in a process of splitting down the renderer implementation into smaller units of logic that can be reused. This change is about extracting pure functions only. DiffTrain build for [aac12ce](facebook@aac12ce)
1 parent dc1c51c commit a5595f4

21 files changed

Lines changed: 157 additions & 291 deletions

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.3.0-native-fb-9c0323e2-20260303
1+
19.3.0-native-fb-aac12ce5-20260303

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<bb79d932cf455dedb5639fb6c9d126a4>>
10+
* @generated SignedSource<<bb6824b56a209eba34c1657b8be1a2b4>>
1111
*/
1212

1313
"use strict";
@@ -410,5 +410,5 @@ __DEV__ &&
410410
exports.useFormStatus = function () {
411411
return resolveDispatcher().useHostTransitionStatus();
412412
};
413-
exports.version = "19.3.0-native-fb-9c0323e2-20260303";
413+
exports.version = "19.3.0-native-fb-aac12ce5-20260303";
414414
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<8735d13b9ac0ce3756f7e1e4082d8bdd>>
10+
* @generated SignedSource<<58ec3bd5c80b677a20ceebd4367d5ce2>>
1111
*/
1212

1313
"use strict";
@@ -209,4 +209,4 @@ exports.useFormState = function (action, initialState, permalink) {
209209
exports.useFormStatus = function () {
210210
return ReactSharedInternals.H.useHostTransitionStatus();
211211
};
212-
exports.version = "19.3.0-native-fb-9c0323e2-20260303";
212+
exports.version = "19.3.0-native-fb-aac12ce5-20260303";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<8735d13b9ac0ce3756f7e1e4082d8bdd>>
10+
* @generated SignedSource<<58ec3bd5c80b677a20ceebd4367d5ce2>>
1111
*/
1212

1313
"use strict";
@@ -209,4 +209,4 @@ exports.useFormState = function (action, initialState, permalink) {
209209
exports.useFormStatus = function () {
210210
return ReactSharedInternals.H.useHostTransitionStatus();
211211
};
212-
exports.version = "19.3.0-native-fb-9c0323e2-20260303";
212+
exports.version = "19.3.0-native-fb-aac12ce5-20260303";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js‎

Lines changed: 11 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<49979c8011e1c248313f66182e00fab9>>
10+
* @generated SignedSource<<899fe9dc68a9266ded24e3c5419514ac>>
1111
*/
1212

1313
/*
@@ -13271,7 +13271,6 @@ __DEV__ &&
1327113271
case "script":
1327213272
nextResource = nextResource.createElement("div");
1327313273
didWarnScriptTags ||
13274-
isScriptDataBlock(newProps) ||
1327513274
(console.error(
1327613275
"Encountered a script tag while rendering React component. Scripts inside React components are never executed when rendering on the client. Consider using template tag instead (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/template)."
1327713276
),
@@ -14455,8 +14454,8 @@ __DEV__ &&
1445514454
);
1445614455
}
1445714456
enableFragmentRefsInstanceHandles &&
14458-
null != childInstance.reactFragments &&
14459-
childInstance.reactFragments.delete(fragmentInstance);
14457+
null != childInstance.unstable_reactFragments &&
14458+
childInstance.unstable_reactFragments.delete(fragmentInstance);
1446014459
}
1446114460
}
1446214461
if (isHostParent(parent)) break;
@@ -23690,37 +23689,6 @@ __DEV__ &&
2369023689
? HostContextNamespaceNone
2369123690
: parentNamespace;
2369223691
}
23693-
function isScriptDataBlock(props) {
23694-
props = props.type;
23695-
if ("string" !== typeof props || "" === props) return !1;
23696-
props = props.toLowerCase();
23697-
if (
23698-
"module" === props ||
23699-
"importmap" === props ||
23700-
"speculationrules" === props
23701-
)
23702-
return !1;
23703-
switch (props) {
23704-
case "application/ecmascript":
23705-
case "application/javascript":
23706-
case "application/x-ecmascript":
23707-
case "application/x-javascript":
23708-
case "text/ecmascript":
23709-
case "text/javascript":
23710-
case "text/javascript1.0":
23711-
case "text/javascript1.1":
23712-
case "text/javascript1.2":
23713-
case "text/javascript1.3":
23714-
case "text/javascript1.4":
23715-
case "text/javascript1.5":
23716-
case "text/jscript":
23717-
case "text/livescript":
23718-
case "text/x-ecmascript":
23719-
case "text/x-javascript":
23720-
return !1;
23721-
}
23722-
return !0;
23723-
}
2372423692
function shouldSetTextContent(type, props) {
2372523693
return (
2372623694
"textarea" === type ||
@@ -24198,9 +24166,9 @@ __DEV__ &&
2419824166
}
2419924167
function addFragmentHandleToInstance(instance, fragmentInstance) {
2420024168
enableFragmentRefsInstanceHandles &&
24201-
(null == instance.reactFragments &&
24202-
(instance.reactFragments = new Set()),
24203-
instance.reactFragments.add(fragmentInstance));
24169+
(null == instance.unstable_reactFragments &&
24170+
(instance.unstable_reactFragments = new Set()),
24171+
instance.unstable_reactFragments.add(fragmentInstance));
2420424172
}
2420524173
function commitNewChildToFragmentInstance(childInstance, fragmentInstance) {
2420624174
if (3 !== childInstance.nodeType) {
@@ -30268,11 +30236,11 @@ __DEV__ &&
3026830236
};
3026930237
(function () {
3027030238
var isomorphicReactPackageVersion = React.version;
30271-
if ("19.3.0-native-fb-9c0323e2-20260303" !== isomorphicReactPackageVersion)
30239+
if ("19.3.0-native-fb-aac12ce5-20260303" !== isomorphicReactPackageVersion)
3027230240
throw Error(
3027330241
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
3027430242
(isomorphicReactPackageVersion +
30275-
"\n - react-dom: 19.3.0-native-fb-9c0323e2-20260303\nLearn more: https://react.dev/warnings/version-mismatch")
30243+
"\n - react-dom: 19.3.0-native-fb-aac12ce5-20260303\nLearn more: https://react.dev/warnings/version-mismatch")
3027630244
);
3027730245
})();
3027830246
("function" === typeof Map &&
@@ -30309,10 +30277,10 @@ __DEV__ &&
3030930277
!(function () {
3031030278
var internals = {
3031130279
bundleType: 1,
30312-
version: "19.3.0-native-fb-9c0323e2-20260303",
30280+
version: "19.3.0-native-fb-aac12ce5-20260303",
3031330281
rendererPackageName: "react-dom",
3031430282
currentDispatcherRef: ReactSharedInternals,
30315-
reconcilerVersion: "19.3.0-native-fb-9c0323e2-20260303"
30283+
reconcilerVersion: "19.3.0-native-fb-aac12ce5-20260303"
3031630284
};
3031730285
internals.overrideHookState = overrideHookState;
3031830286
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -30462,5 +30430,5 @@ __DEV__ &&
3046230430
listenToAllSupportedEvents(container);
3046330431
return new ReactDOMHydrationRoot(initialChildren);
3046430432
};
30465-
exports.version = "19.3.0-native-fb-9c0323e2-20260303";
30433+
exports.version = "19.3.0-native-fb-aac12ce5-20260303";
3046630434
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<6657258112820e30cb78e484787b74e5>>
10+
* @generated SignedSource<<093b0a987ea00fc74dd675669e66b445>>
1111
*/
1212

1313
/*
@@ -9459,8 +9459,8 @@ function commitFragmentInstanceDeletionEffects(fiber) {
94599459
);
94609460
}
94619461
enableFragmentRefsInstanceHandles &&
9462-
null != childInstance.reactFragments &&
9463-
childInstance.reactFragments.delete(fragmentInstance);
9462+
null != childInstance.unstable_reactFragments &&
9463+
childInstance.unstable_reactFragments.delete(fragmentInstance);
94649464
}
94659465
}
94669466
if (isHostParent(parent)) break;
@@ -15934,8 +15934,9 @@ function addFragmentHandleToFiber(child, fragmentInstance) {
1593415934
}
1593515935
function addFragmentHandleToInstance(instance, fragmentInstance) {
1593615936
enableFragmentRefsInstanceHandles &&
15937-
(null == instance.reactFragments && (instance.reactFragments = new Set()),
15938-
instance.reactFragments.add(fragmentInstance));
15937+
(null == instance.unstable_reactFragments &&
15938+
(instance.unstable_reactFragments = new Set()),
15939+
instance.unstable_reactFragments.add(fragmentInstance));
1593915940
}
1594015941
function commitNewChildToFragmentInstance(childInstance, fragmentInstance) {
1594115942
if (3 !== childInstance.nodeType) {
@@ -17791,14 +17792,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1779117792
};
1779217793
var isomorphicReactPackageVersion$jscomp$inline_2048 = React.version;
1779317794
if (
17794-
"19.3.0-native-fb-9c0323e2-20260303" !==
17795+
"19.3.0-native-fb-aac12ce5-20260303" !==
1779517796
isomorphicReactPackageVersion$jscomp$inline_2048
1779617797
)
1779717798
throw Error(
1779817799
formatProdErrorMessage(
1779917800
527,
1780017801
isomorphicReactPackageVersion$jscomp$inline_2048,
17801-
"19.3.0-native-fb-9c0323e2-20260303"
17802+
"19.3.0-native-fb-aac12ce5-20260303"
1780217803
)
1780317804
);
1780417805
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17820,10 +17821,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1782017821
};
1782117822
var internals$jscomp$inline_2610 = {
1782217823
bundleType: 0,
17823-
version: "19.3.0-native-fb-9c0323e2-20260303",
17824+
version: "19.3.0-native-fb-aac12ce5-20260303",
1782417825
rendererPackageName: "react-dom",
1782517826
currentDispatcherRef: ReactSharedInternals,
17826-
reconcilerVersion: "19.3.0-native-fb-9c0323e2-20260303"
17827+
reconcilerVersion: "19.3.0-native-fb-aac12ce5-20260303"
1782717828
};
1782817829
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1782917830
var hook$jscomp$inline_2611 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17930,4 +17931,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1793017931
listenToAllSupportedEvents(container);
1793117932
return new ReactDOMHydrationRoot(initialChildren);
1793217933
};
17933-
exports.version = "19.3.0-native-fb-9c0323e2-20260303";
17934+
exports.version = "19.3.0-native-fb-aac12ce5-20260303";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js‎

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<0b1186a8473e53d44f4b5bdca5cf0ccb>>
10+
* @generated SignedSource<<88b77666d40f7bb88c417a8ea126bbc6>>
1111
*/
1212

1313
/*
@@ -10211,8 +10211,8 @@ function commitFragmentInstanceDeletionEffects(fiber) {
1021110211
);
1021210212
}
1021310213
enableFragmentRefsInstanceHandles &&
10214-
null != childInstance.reactFragments &&
10215-
childInstance.reactFragments.delete(fragmentInstance);
10214+
null != childInstance.unstable_reactFragments &&
10215+
childInstance.unstable_reactFragments.delete(fragmentInstance);
1021610216
}
1021710217
}
1021810218
if (isHostParent(parent)) break;
@@ -17914,8 +17914,9 @@ function addFragmentHandleToFiber(child, fragmentInstance) {
1791417914
}
1791517915
function addFragmentHandleToInstance(instance, fragmentInstance) {
1791617916
enableFragmentRefsInstanceHandles &&
17917-
(null == instance.reactFragments && (instance.reactFragments = new Set()),
17918-
instance.reactFragments.add(fragmentInstance));
17917+
(null == instance.unstable_reactFragments &&
17918+
(instance.unstable_reactFragments = new Set()),
17919+
instance.unstable_reactFragments.add(fragmentInstance));
1791917920
}
1792017921
function commitNewChildToFragmentInstance(childInstance, fragmentInstance) {
1792117922
if (3 !== childInstance.nodeType) {
@@ -19780,14 +19781,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1978019781
};
1978119782
var isomorphicReactPackageVersion$jscomp$inline_2396 = React.version;
1978219783
if (
19783-
"19.3.0-native-fb-9c0323e2-20260303" !==
19784+
"19.3.0-native-fb-aac12ce5-20260303" !==
1978419785
isomorphicReactPackageVersion$jscomp$inline_2396
1978519786
)
1978619787
throw Error(
1978719788
formatProdErrorMessage(
1978819789
527,
1978919790
isomorphicReactPackageVersion$jscomp$inline_2396,
19790-
"19.3.0-native-fb-9c0323e2-20260303"
19791+
"19.3.0-native-fb-aac12ce5-20260303"
1979119792
)
1979219793
);
1979319794
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19809,10 +19810,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1980919810
};
1981019811
var internals$jscomp$inline_2403 = {
1981119812
bundleType: 0,
19812-
version: "19.3.0-native-fb-9c0323e2-20260303",
19813+
version: "19.3.0-native-fb-aac12ce5-20260303",
1981319814
rendererPackageName: "react-dom",
1981419815
currentDispatcherRef: ReactSharedInternals,
19815-
reconcilerVersion: "19.3.0-native-fb-9c0323e2-20260303",
19816+
reconcilerVersion: "19.3.0-native-fb-aac12ce5-20260303",
1981619817
getLaneLabelMap: function () {
1981719818
for (
1981819819
var map = new Map(), lane = 1, index$338 = 0;
@@ -19935,4 +19936,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1993519936
listenToAllSupportedEvents(container);
1993619937
return new ReactDOMHydrationRoot(initialChildren);
1993719938
};
19938-
exports.version = "19.3.0-native-fb-9c0323e2-20260303";
19939+
exports.version = "19.3.0-native-fb-aac12ce5-20260303";

0 commit comments

Comments
 (0)