Skip to content

Commit a3bdb5d

Browse files
committed
feat: more percise error handling
1 parent 6fda8e5 commit a3bdb5d

4 files changed

Lines changed: 9 additions & 12 deletions

File tree

src/sagittarius/retry.rs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -71,14 +71,10 @@ pub async fn create_channel_with_retry(
7171
retries += 1;
7272

7373
if retries >= MAX_RETRIES {
74-
log::error!(
74+
panic!(
7575
"Sagittarius connection retries exhausted channel={} url={} attempts={} last_error={:?}",
76-
channel_name,
77-
url,
78-
MAX_RETRIES,
79-
err
76+
channel_name, url, MAX_RETRIES, err
8077
);
81-
panic!("Reached max retries to url {}", url)
8278
}
8379
}
8480
}

src/startup/dynamic_mode.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,7 @@ pub async fn run(
170170
result = &mut server_task => {
171171
match result {
172172
Ok(()) => log::warn!("gRPC server task exited unexpectedly; shutting down"),
173+
Err(err) if err.is_panic() => {}
173174
Err(err) => log::error!("gRPC server task failed; shutting down error={:?}", err),
174175
}
175176
flow_task.abort();
@@ -178,6 +179,7 @@ pub async fn run(
178179
result = &mut test_execution_task => {
179180
match result {
180181
Ok(()) => log::warn!("Test execution stream task exited unexpectedly; shutting down"),
182+
Err(err) if err.is_panic() => {}
181183
Err(err) => log::error!("Test execution stream task failed; shutting down error={:?}", err),
182184
}
183185
server_task.abort();
@@ -186,6 +188,7 @@ pub async fn run(
186188
result = &mut flow_task => {
187189
match result {
188190
Ok(()) => log::warn!("Flow stream task exited unexpectedly; shutting down"),
191+
Err(err) if err.is_panic() => {}
189192
Err(err) => log::error!("Flow stream task failed; shutting down error={:?}", err),
190193
}
191194
server_task.abort();

src/startup/mod.rs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ pub async fn run(
3030
client
3131
}
3232
Err(err) => {
33-
log::error!("Failed to connect to NATS: {:?}", err);
3433
panic!("Failed to connect to NATS server: {:?}", err)
3534
}
3635
};
@@ -61,12 +60,10 @@ pub async fn run(
6160
Arc::new(kv)
6261
}
6362
Err(err) => {
64-
log::error!(
63+
panic!(
6564
"Failed to open NATS key-value store bucket={} error={:?}",
66-
config.nats.bucket,
67-
err
68-
);
69-
panic!("Failed to get key-value store: {:?}", err)
65+
config.nats.bucket, err
66+
)
7067
}
7168
};
7269

src/startup/static_mode.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ pub async fn run(
6868
result = &mut server_task => {
6969
match result {
7070
Ok(()) => log::warn!("gRPC server task exited unexpectedly; shutting down"),
71+
Err(err) if err.is_panic() => {}
7172
Err(err) => log::error!("gRPC server task failed; shutting down error={:?}", err),
7273
}
7374
}

0 commit comments

Comments
 (0)