ref: cargo clippy

Author: raphael-goetz

crates/cli/src/analyser/data_type.rs

@@ -47,7 +47,7 @@ impl Analyser {
             ));
         }
 
-        if dt.r#type == "" {
+        if dt.r#type.is_empty() {
             self.reporter.add(Diagnose::new(
                 dt.identifier.clone(),
                 adt.original_definition.clone(),

crates/cli/src/analyser/flow_type.rs

@@ -77,7 +77,7 @@ impl Analyser {
             ));
         }
 
-        if &flow.signature == "" {
+        if flow.signature.is_empty() {
             self.reporter.add(Diagnose::new(
                 name.clone(),
                 original.clone(),

crates/cli/src/analyser/function.rs

@@ -78,7 +78,7 @@ impl Analyser {
             ));
         }
 
-        if function.signature == "" {
+        if function.signature.is_empty() {
             self.reporter.add(Diagnose::new(
                 name.clone(),
                 original.clone(),

crates/cli/src/command/search_module.rs

@@ -102,7 +102,7 @@ pub fn search_module(name: Option<String>, path: Option<String>) {
         .map(|x| x.into_module())
         .collect();
 
-    let summary = summary_table(&mods);
+    let summary = summary_table(mods);
     success_table(summary);
 
     success(format!(

crates/cli/src/command/watch.rs

@@ -39,16 +39,15 @@ pub async fn watch_for_changes(path: Option<String>, with_warning: bool) {
                         last_run = Instant::now();
                     }
                 }
-                EventKind::Remove(_) => {
-                    if last_run.elapsed() > Duration::from_millis(500) {
+                EventKind::Remove(_)
+                    if last_run.elapsed() > Duration::from_millis(500) => {
                         default(String::from(
                             "\n\n\n--------------------------------------------------------------------------\n\n",
                         ));
                         info(String::from("Change detected! Regenerating report..."));
                         Analyser::new(dir_path.as_str()).report(false, with_warning);
                         last_run = Instant::now();
                     }
-                }
                 _ => {}
             }
         }

crates/cli/src/reader.rs

@@ -108,15 +108,14 @@ impl Reader {
 
             // Handle direct module definition file.
             let module_definition_file = module_path.join("module.json");
-            if module_definition_file.is_file() {
-                if let Ok(meta_result) = Meta::read_from_file(
+            if module_definition_file.is_file()
+                && let Ok(meta_result) = Meta::read_from_file(
                     module_name.clone(),
                     MetaType::ModuleDefinition,
                     module_definition_file,
                 ) {
                     result.push(meta_result);
                 }
-            }
 
             // Handle all typed definition directories.
             let type_entries = match fs::read_dir(&module_path) {