Implement config validation

Author: Taucher2003

lib/code0/identities.rb

@@ -18,5 +18,7 @@
 module Code0
   module Identities
     class Error < StandardError; end
+    class MissingConfigurationError < Error; end
+    class InvalidConfigurationError < Error; end
   end
 end

lib/code0/identities/identity_provider.rb

@@ -24,11 +24,11 @@ def load_identity(provider_id, params)
           raise Error, "Provider with id '#{provider_id}' is not configured, did you forget to use add_provider"
         end
 
-        provider.load_identity(params)
+        provider.load_identity(**params)
       end
 
-      def [](provider_id)
-        providers[provider_id]
+      def self.for_type(provider_type)
+        Identities::Provider.const_get(provider_type.capitalize)
       end
     end
   end

lib/code0/identities/provider/base_oauth.rb

@@ -10,7 +10,7 @@ def initialize(config_loader)
           @config_loader = config_loader
         end
 
-        def config_attributes
+        def validate_config!
           raise NotImplementedError
         end
 

lib/code0/identities/provider/discord.rb

@@ -4,11 +4,14 @@ module Code0
   module Identities
     module Provider
       class Discord < BaseOauth
-        def config_attributes
-          {
-            required: %i[client_id client_secret redirect_uri],
-            optional: %i[provider_name]
-          }
+        def validate_config!
+          required_keys = %i[redirect_uri client_id client_secret]
+
+          missing_keys = required_keys - config.keys
+          invalid_keys = config.keys - required_keys - [:provider_name]
+
+          raise MissingConfigurationError, "Missing: #{missing_keys.inspect}" if missing_keys.any?
+          raise InvalidConfigurationError, "Invalid: #{invalid_keys.inspect}" if invalid_keys.any?
         end
 
         def token_url

lib/code0/identities/provider/github.rb

@@ -4,11 +4,14 @@ module Code0
   module Identities
     module Provider
       class Github < BaseOauth
-        def config_attributes
-          {
-            required: %i[client_id client_secret redirect_uri],
-            optional: %i[provider_name]
-          }
+        def validate_config!
+          required_keys = %i[redirect_uri client_id client_secret]
+
+          missing_keys = required_keys - config.keys
+          invalid_keys = config.keys - required_keys - [:provider_name]
+
+          raise MissingConfigurationError, "Missing: #{missing_keys.inspect}" if missing_keys.any?
+          raise InvalidConfigurationError, "Invalid: #{invalid_keys.inspect}" if invalid_keys.any?
         end
 
         def token_url

lib/code0/identities/provider/gitlab.rb

@@ -4,11 +4,14 @@ module Code0
   module Identities
     module Provider
       class Gitlab < BaseOauth
-        def config_attributes
-          {
-            required: %i[base_url client_id client_secret redirect_uri],
-            optional: %i[provider_name]
-          }
+        def validate_config!
+          required_keys = %i[base_url redirect_uri client_id client_secret]
+
+          missing_keys = required_keys - config.keys
+          invalid_keys = config.keys - required_keys - [:provider_name]
+
+          raise MissingConfigurationError, "Missing: #{missing_keys.inspect}" if missing_keys.any?
+          raise InvalidConfigurationError, "Invalid: #{invalid_keys.inspect}" if invalid_keys.any?
         end
 
         def base_url

lib/code0/identities/provider/google.rb

@@ -4,11 +4,14 @@ module Code0
   module Identities
     module Provider
       class Google < BaseOauth
-        def config_attributes
-          {
-            required: %i[client_id client_secret redirect_uri],
-            optional: %i[provider_name]
-          }
+        def validate_config!
+          required_keys = %i[redirect_uri client_id client_secret]
+
+          missing_keys = required_keys - config.keys
+          invalid_keys = config.keys - required_keys - [:provider_name]
+
+          raise MissingConfigurationError, "Missing: #{missing_keys.inspect}" if missing_keys.any?
+          raise InvalidConfigurationError, "Invalid: #{invalid_keys.inspect}" if invalid_keys.any?
         end
 
         def base_url

lib/code0/identities/provider/microsoft.rb

@@ -4,11 +4,14 @@ module Code0
   module Identities
     module Provider
       class Microsoft < BaseOauth
-        def config_attributes
-          {
-            required: %i[client_id client_secret redirect_uri],
-            optional: %i[provider_name]
-          }
+        def validate_config!
+          required_keys = %i[redirect_uri client_id client_secret]
+
+          missing_keys = required_keys - config.keys
+          invalid_keys = config.keys - required_keys - [:provider_name]
+
+          raise MissingConfigurationError, "Missing: #{missing_keys.inspect}" if missing_keys.any?
+          raise InvalidConfigurationError, "Invalid: #{invalid_keys.inspect}" if invalid_keys.any?
         end
 
         def base_url

lib/code0/identities/provider/oidc.rb

@@ -4,11 +4,14 @@ module Code0
   module Identities
     module Provider
       class Oidc < BaseOauth
-        def config_attributes
-          {
-            required: %i[client_id client_secret redirect_uri token_url user_details_url authorization_url],
-            optional: %i[provider_name]
-          }
+        def validate_config!
+          required_keys = %i[client_id client_secret redirect_uri token_url user_details_url authorization_url]
+
+          missing_keys = required_keys - config.keys
+          invalid_keys = config.keys - required_keys - [:provider_name]
+
+          raise MissingConfigurationError, "Missing: #{missing_keys.inspect}" if missing_keys.any?
+          raise InvalidConfigurationError, "Invalid: #{invalid_keys.inspect}" if invalid_keys.any?
         end
 
         def token_url

lib/code0/identities/provider/saml.rb

@@ -10,11 +10,14 @@ def initialize(config_loader)
           @config_loader = config_loader
         end
 
-        def config_attributes
-          {
-            required: %i[],
-            optional: %i[provider_name metadata_url settings response_settings attribute_statements]
-          }
+        def validate_config!
+          required_keys = config[:metadata_url].nil? ? %i[settings] : %i[metadata_url]
+
+          missing_keys = required_keys - config.keys
+          invalid_keys = config.keys - %i[provider_name metadata_url settings response_settings attribute_statements]
+
+          raise MissingConfigurationError, "Missing: #{missing_keys.inspect}" if missing_keys.any?
+          raise InvalidConfigurationError, "Invalid: #{invalid_keys.inspect}" if invalid_keys.any?
         end
 
         def authorization_url