ref: applied clippy fix

Author: raphael-goetz

.github/workflows/build-and-test.yml

@@ -83,7 +83,16 @@ jobs:
     needs: build
     runs-on: ubuntu-latest
     steps:
+      - name: Cache cargo registry
+        uses: actions/cache@v4
+        with:
+          path: |
+            ~/.cargo/registry
+            ~/.cargo/git
+            target
+          key: ${{ runner.os }}-cargo-build-${{ hashFiles('**/Cargo.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-cargo-
+
       - name: Run Tests
-        run: PATH=${{ runner.temp }}/proto/bin:$PATH cargo test
-        env:
-          RUST_BACKTRACE: 'full'
+        run:  cargo test --verbose --all-features

crates/base/src/config.rs

@@ -62,7 +62,8 @@ impl AdapterConfig {
         let nats_bucket =
             code0_flow::flow_config::env_with_default("NATS_BUCKET", String::from("flow_store"));
         let grpc_port = code0_flow::flow_config::env_with_default("GRPC_PORT", 50051);
-        let grpc_host = code0_flow::flow_config::env_with_default("GRPC_HOST", String::from("localhost"));
+        let grpc_host =
+            code0_flow::flow_config::env_with_default("GRPC_HOST", String::from("localhost"));
         let aquila_url = code0_flow::flow_config::env_with_default(
             "AQUILA_URL",
             String::from("grpc://localhost:50051"),
@@ -75,7 +76,8 @@ impl AdapterConfig {
             "DEFINITION_PATH",
             String::from("./definition.yaml"),
         );
-        let with_health_service = code0_flow::flow_config::env_with_default("WITH_HEALTH_SERVICE", false);
+        let with_health_service =
+            code0_flow::flow_config::env_with_default("WITH_HEALTH_SERVICE", false);
 
         Self {
             environment,

crates/base/src/lib.rs

@@ -17,10 +17,10 @@ pub fn extract_flow_setting_field(
 
         let obj = setting.object.as_ref()?;
         obj.fields.iter().find_map(|(k, v)| {
-            if k == field_name {
-                if let Some(Kind::StringValue(s)) = &v.kind {
-                    return Some(s.clone());
-                }
+            if k == field_name
+                && let Some(Kind::StringValue(s)) = &v.kind
+            {
+                return Some(s.clone());
             }
             None
         })

crates/base/src/runner.rs

@@ -73,7 +73,11 @@ impl<C: LoadConfig> ServerRunner<C> {
                     .await;
             });
 
-            log::info!("Health server started at {}:{}", config.grpc_host, config.grpc_port);
+            log::info!(
+                "Health server started at {}:{}",
+                config.grpc_host,
+                config.grpc_port
+            );
         }
 
         self.server.init(&self.context).await?;

crates/base/src/store.rs

@@ -1,9 +1,9 @@
 use crate::traits::IdentifiableFlow;
 use async_nats::jetstream::kv::Config;
+use code0_flow::flow_validator::verify_flow;
 use futures_lite::StreamExt;
 use prost::Message;
 use tucana::shared::{ExecutionFlow, ValidationFlow, Value};
-use code0_flow::flow_validator::verify_flow;
 
 pub struct AdapterStore {
     client: async_nats::Client,
@@ -30,10 +30,11 @@ impl AdapterStore {
                 bucket: bucket.clone(),
                 ..Default::default()
             })
-            .await {
+            .await
+        {
             Ok(_) => {
                 log::info!("Successfully created NATS bucket");
-            },
+            }
             Err(err) => panic!("Failed to create NATS bucket: {:?}", err),
         }
 
@@ -79,17 +80,16 @@ impl AdapterStore {
         };
 
         while let Ok(Some(key)) = keys.try_next().await {
-
             if !Self::is_matching_key(&pattern, &key) {
                 continue;
             }
 
             if let Ok(Some(bytes)) = self.kv.get(key).await {
                 let decoded_flow = ValidationFlow::decode(bytes);
-                if let Ok(flow) = decoded_flow {
-                    if id.identify(&flow) {
-                        collector.push(flow);
-                    }
+                if let Ok(flow) = decoded_flow
+                    && id.identify(&flow)
+                {
+                    collector.push(flow.clone());
                 };
             }
         }
@@ -132,9 +132,7 @@ impl AdapterStore {
 
         match result {
             Ok(message) => match Value::decode(message.payload) {
-                Ok(value) => {
-                    Some(value)
-                }
+                Ok(value) => Some(value),
                 Err(err) => {
                     log::error!("Failed to decode response from NATS server: {:?}", err);
                     None
@@ -151,7 +149,7 @@ impl AdapterStore {
         ExecutionFlow {
             flow_id: flow.flow_id,
             starting_node: flow.starting_node,
-            input_value: input_value,
+            input_value,
         }
     }
 

crates/http/src/request.rs

@@ -46,6 +46,12 @@ pub struct HeaderMap {
     pub fields: HashMap<String, String>,
 }
 
+impl Default for HeaderMap {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl HeaderMap {
     pub fn new() -> Self {
         HeaderMap {
@@ -228,10 +234,10 @@ fn parse_request(
         };
 
         let mut body = vec![0; size];
-        if let Ok(_) = buf_reader.read_exact(&mut body) {
-            if let Ok(json_value) = serde_json::from_slice::<serde_json::Value>(&body) {
-                body_values.insert("body".to_string(), from_json_value(json_value));
-            }
+        if buf_reader.read_exact(&mut body).is_ok()
+            && let Ok(json_value) = serde_json::from_slice::<serde_json::Value>(&body)
+        {
+            body_values.insert("body".to_string(), from_json_value(json_value));
         }
     };