Adjust FlowSettingsIdentifier - #191
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates flow setting identifier strings to match renamed settings (per issue #190) so adapters can correctly identify matching flows.
Changes:
- REST adapter: update HTTP method/url flow setting IDs to
httpMethodandhttpURL(and align debug log text). - Cron adapter: update cron-related flow setting IDs from
CRON_*to lower camelCase (e.g.,cronMinute,cronDayOfMonth).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| adapter/rest/src/route.rs | Switch REST flow-setting lookups to new httpMethod / httpURL identifiers and update related debug log text. |
| adapter/cron/src/main.rs | Switch Cron flow-setting lookups from CRON_* identifiers to new lower camelCase identifiers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #190