Skip to content

Adjust FlowSettingsIdentifier #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raphael-goetz merged 1 commit into from
Apr 11, 2026
Merged

Adjust FlowSettingsIdentifier #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions adapter/cron/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,19 +57,19 @@ fn extract_flow_setting_field(flow: &ValidationFlow, name: &str) -> Option<Strin

impl IdentifiableFlow for Time {
fn identify(&self, flow: &tucana::shared::ValidationFlow) -> bool {
let Some(minute) = extract_flow_setting_field(flow, "CRON_MINUTE") else {
let Some(minute) = extract_flow_setting_field(flow, "cronMinute") else {
return false;
};
let Some(hour) = extract_flow_setting_field(flow, "CRON_HOUR") else {
let Some(hour) = extract_flow_setting_field(flow, "cronHour") else {
return false;
Comment thread
raphael-goetz marked this conversation as resolved.
};
let Some(dom) = extract_flow_setting_field(flow, "CRON_DAY_OF_MONTH") else {
let Some(dom) = extract_flow_setting_field(flow, "cronDayOfMonth") else {
return false;
};
let Some(month) = extract_flow_setting_field(flow, "CRON_MONTH") else {
let Some(month) = extract_flow_setting_field(flow, "cronMonth") else {
return false;
};
let Some(dow) = extract_flow_setting_field(flow, "CRON_DAY_OF_WEEK") else {
let Some(dow) = extract_flow_setting_field(flow, "cronDayOfWeek") else {
return false;
};

Expand Down
6 changes: 3 additions & 3 deletions adapter/rest/src/route.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ impl IdentifiableFlow for RequestRoute {
let method_str = flow
.settings
.iter()
.find(|s| s.flow_setting_id == "HTTP_METHOD")
.find(|s| s.flow_setting_id == "httpMethod")
.and_then(|s| s.value.as_ref())
.and_then(|v| v.kind.as_ref())
.and_then(|k| match k {
Expand All @@ -42,9 +42,9 @@ impl IdentifiableFlow for RequestRoute {
let regex_str_v = flow
.settings
.iter()
.find(|s| s.flow_setting_id == "HTTP_URL");
.find(|s| s.flow_setting_id == "httpURL");

log::debug!("Extracted: {:?} as HTTP_URL", &regex_str_v);
log::debug!("Extracted: {:?} as httpURL", &regex_str_v);

let regex_str = regex_str_v
.and_then(|s| s.value.as_ref())
Expand Down