Merge pull request #26 from code0-tech/feat/#25

Order of parameters and settings annotations is inverted

Author: nicosammito

ts/src/decorators/event.dec.ts

@@ -3,6 +3,6 @@ import {EventSettingProps} from "../models/event.model";
 export const EventSetting = (setting: EventSettingProps): ClassDecorator =>
     (target) => {
         const settings = Reflect.getMetadata('hercules:flow_settings', target) || [];
-        settings.push(setting);
+        settings.unshift(setting);
         Reflect.defineMetadata('hercules:flow_settings', settings, target);
     }

ts/src/decorators/function.dec.ts

@@ -12,6 +12,6 @@ export const ThrowsError = (throwsError: boolean = true): ClassDecorator =>
 export const Parameter = (parameter: FunctionParameterProps): ClassDecorator =>
     (target) => {
         const parameters = Reflect.getMetadata('hercules:function_parameters', target) || [];
-        parameters.push(parameter);
+        parameters.unshift(parameter);
         Reflect.defineMetadata('hercules:function_parameters', parameters, target);
     }

ts/test/index.test.ts

@@ -1,9 +1,44 @@
+import "reflect-metadata";
 import { describe, expect, it } from "vitest";
+import { Parameter } from "../src/decorators/function.dec";
+import { EventSetting } from "../src/decorators/event.dec";
 
-describe("index", () => {
-    // mock test
-    it("should pass", () => {
-        // compare true to true
-        expect(true).toBe(true);
+describe("Parameter decorator", () => {
+    it("preserves source order across multiple decorators", () => {
+        @Parameter({ runtimeName: "first" })
+        @Parameter({ runtimeName: "second" })
+        @Parameter({ runtimeName: "third" })
+        class Foo {}
+
+        const parameters = Reflect.getMetadata("hercules:function_parameters", Foo);
+        expect(parameters.map((p: { runtimeName: string }) => p.runtimeName)).toEqual([
+            "first",
+            "second",
+            "third",
+        ]);
+    });
+
+    it("works for a single parameter", () => {
+        @Parameter({ runtimeName: "only" })
+        class Bar {}
+
+        const parameters = Reflect.getMetadata("hercules:function_parameters", Bar);
+        expect(parameters.map((p: { runtimeName: string }) => p.runtimeName)).toEqual(["only"]);
+    });
+});
+
+describe("EventSetting decorator", () => {
+    it("preserves source order across multiple decorators", () => {
+        @EventSetting({ identifier: "first" })
+        @EventSetting({ identifier: "second" })
+        @EventSetting({ identifier: "third" })
+        class Event {}
+
+        const settings = Reflect.getMetadata("hercules:flow_settings", Event);
+        expect(settings.map((s: { identifier: string }) => s.identifier)).toEqual([
+            "first",
+            "second",
+            "third",
+        ]);
     });
-}); 
+});