Skip to content

Commit 099fbdd

Browse files
author
nicosammito
committed
chore: add TODO for improving value type resolution in DNodeValidation hook
1 parent ed74d6a commit 099fbdd

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

src/components/d-flow-validation/DNodeValidation.hook.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ export const useNodeValidation = (
7272

7373
const resolveValueType = React.useCallback(
7474
(value: NodeParameterValue, expectedDT?: DataTypeView) => {
75+
76+
//TODO seperate check for flow input, return type and parameter type to properly resolve variables
7577
if ((isNode(value) && expectedDT?.variant !== "NODE") || isReference(value)) {
7678
const node = flowService.getNodeById(flowId, value.__typename == "NodeFunctionIdWrapper" ? value.id : value.__typename === "ReferenceValue" ? value.nodeFunctionId : undefined)
7779
const fn = functionService.getById(node?.functionDefinition?.id!!)!!

0 commit comments

Comments
 (0)