Properly exit when requesting a build that does not exist

Author: Taucher2003

bin/discord

@@ -111,6 +111,9 @@ bot.interaction_create do |event|
     SemanticLogger['DiscordBot'].info('Executing command', command: command)
     result = Pyxis::Cli.start(command, { debug: true })
     color = '#4caf50'
+  rescue Pyxis::MessageError => e
+    result = e.message
+    color = '#f44336'
   rescue Thor::Error, Pyxis::Error => e
     result = "#{e.class}\n#{e.message}"
     color = '#f44336'

lib/pyxis.rb

@@ -7,6 +7,7 @@
 
 module Pyxis
   Error = Class.new(StandardError)
+  MessageError = Class.new(Pyxis::Error)
 end
 
 loader = Zeitwerk::Loader.for_gem

lib/pyxis/commands/components.rb

@@ -10,6 +10,8 @@ class Components < Thor
       def info
         component_versions = ManagedVersioning::ComponentInfo.new(options[:build]).execute
 
+        raise Pyxis::MessageError, 'This build does not exist' if component_versions.nil?
+
         result = 'Versions of each component'
         component_versions.each do |component, version|
           result += "\n#{component}: #{version}"

lib/pyxis/gitlab_client.rb

@@ -43,9 +43,14 @@ def self.enhance_faraday(faraday)
           json = response.body.blank? ? nil : JSON.parse(response.body)
 
           if json.is_a?(Hash)
-            Thor::CoreExt::HashWithIndifferentAccess.new(json)
+            Thor::CoreExt::HashWithIndifferentAccess.new(
+              {
+                body: Thor::CoreExt::HashWithIndifferentAccess.new(json),
+                response: response,
+              }
+            )
           else
-            json || response
+            response
           end
         end
       end

lib/pyxis/managed_versioning/component_info.rb

@@ -15,7 +15,9 @@ def execute
         pipeline = GitlabClient.client.get_json(
           "/api/v4/projects/#{Project::Reticulum.api_gitlab_path}/pipelines/#{build_id}"
         )
-        reticulum_sha = pipeline.sha
+        return nil if pipeline.response.status == 404
+
+        reticulum_sha = pipeline.body.sha
 
         components = {}