feat: made velorum de-/activatable

Author: raphael-goetz

app/services/velorum/models_service.rb

@@ -2,16 +2,28 @@
 
 module Velorum
   class ModelsService
-    def initialize(client: Sagittarius::Velorum::Client.new)
+    def initialize(client: nil, config: Sagittarius::Configuration.config[:velorum])
       @client = client
+      @config = config
     end
 
     def execute
+      unless config[:enabled]
+        raise GraphQL::ExecutionError.new(
+          'Velorum is disabled',
+          extensions: { code: 'VELORUM_DISABLED' }
+        )
+      end
+
       client.models.models
     end
 
     private
 
-    attr_reader :client
+    attr_reader :config
+
+    def client
+      @client ||= Sagittarius::Velorum::Client.new
+    end
   end
 end

config/sagittarius.example.yml

@@ -27,6 +27,7 @@ rails:
   secret_key_base: MVMD6CtQwEWrQ28TdokQakbG2FG5abOn
 
 velorum:
+  enabled: true
   host: 'localhost:50052'
   security_token:
   jwt_ttl_minutes: 8

lib/sagittarius/configuration.rb

@@ -53,6 +53,7 @@ def self.defaults
           secret_key_base: 'MVMD6CtQwEWrQ28TdokQakbG2FG5abOn',
         },
         velorum: {
+          enabled: true,
           host: 'localhost:50052',
           security_token: nil,
           jwt_ttl_minutes: 8,

spec/requests/graphql/query/velorum_models_query_spec.rb

@@ -63,4 +63,24 @@
     )
     expect(client).to have_received(:models)
   end
+
+  context 'when Velorum is disabled' do
+    before do
+      allow(Sagittarius::Configuration).to receive(:config)
+        .and_return(velorum: { enabled: false })
+    end
+
+    it 'returns a GraphQL error without creating a Velorum client' do
+      post_graphql(query)
+
+      expect(graphql_data_at(:velorum_models)).to be_nil
+      expect(graphql_errors).to contain_exactly(
+        a_hash_including(
+          'message' => 'Velorum is disabled',
+          'extensions' => a_hash_including('code' => 'VELORUM_DISABLED')
+        )
+      )
+      expect(Sagittarius::Velorum::Client).not_to have_received(:new)
+    end
+  end
 end