Skip to content

Commit 2278d99

Browse files
committed
Improve logging for failed module updates
1 parent 40dac57 commit 2278d99

2 files changed

Lines changed: 11 additions & 1 deletion

File tree

app/grpc/module_handler.rb

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,15 @@ def update(request, _call)
1111

1212
logger.debug("ModuleHandler#update response: #{response.inspect}")
1313
unless response.success?
14+
details = if response.payload[:details].is_a?(ActiveModel::Errors)
15+
{ error_code: response.payload[:error_code], details: response.payload[:details].full_messages }
16+
else
17+
response.payload
18+
end
19+
1420
logger.warn(message: 'Failed to update modules',
1521
error: response.message,
16-
details: response.payload)
22+
details: details)
1723
end
1824

1925
response.to_grpc_response(Tucana::Sagittarius::ModuleUpdateResponse)

app/services/runtimes/grpc/modules/update_service.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,10 @@ def update_module_definitions(module_records, t)
133133

134134
next if db_module_definitions[index].save
135135

136+
logger.error(message: 'Failed to update runtime module definition',
137+
module_identifier: grpc_module.identifier,
138+
errors: db_module_definitions[index].errors.full_messages)
139+
136140
t.rollback_and_return! ServiceResponse.error(
137141
message: 'Failed to update runtime module definition',
138142
error_code: :invalid_runtime_module_definition,

0 commit comments

Comments
 (0)