Apply suggestions from code review

Co-authored-by: Niklas van Schrick <mc.taucher2003@gmail.com>
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>

Author: raphael-goetz

app/models/concerns/namespace_parent.rb

@@ -13,7 +13,7 @@ def ensure_namespace
     ns = build_namespace
     if persisted?
       ns.save
-      ns.ensure_personal_namespace_administrator! if is_a?(User)
+      ns.ensure_personal_namespace_administrator! if ns.user_type?
     end
     ns
   end

app/policies/namespace_member_policy.rb

@@ -8,6 +8,8 @@ class NamespaceMemberPolicy < BasePolicy
 
   rule { member_is_self }.enable :delete_member
 
-  rule { personal_namespace_owner_member }.prevent :delete_member
-  rule { personal_namespace_owner_member }.prevent :assign_member_roles
+  rule { personal_namespace_owner_member }.policy do
+    prevent :delete_member
+    prevent :assign_member_roles
+  end
 end

app/policies/namespace_role_policy.rb

@@ -7,7 +7,9 @@ class NamespaceRolePolicy < BasePolicy
     subject.namespace.personal_namespace_owner_administrator_role?(subject)
   end
 
-  rule { personal_namespace_owner_administrator_role }.prevent :delete_namespace_role
-  rule { personal_namespace_owner_administrator_role }.prevent :assign_role_abilities
-  rule { personal_namespace_owner_administrator_role }.prevent :assign_role_projects
+  rule { personal_namespace_owner_administrator_role }.policy do
+    prevent :delete_namespace_role
+    prevent :assign_role_abilities
+    prevent :assign_role_projects
+  end
 end

spec/policies/namespace_project_policy_spec.rb

@@ -25,6 +25,6 @@
     let(:namespace) { current_user.ensure_namespace }
     let(:namespace_project) { create(:namespace_project, namespace: namespace) }
 
-    it { is_expected.to be_allowed(:read_namespace_project) }
+    it { is_expected.to be_allowed(:update_namespace_project) }
   end
 end