feat: changed restrictions on execution node results

Author: raphael-goetz

app/graphql/types/execution_parameter_result_type.rb

@@ -9,7 +9,7 @@ class ExecutionParameterResultType < Types::BaseObject
           null: false,
           description: 'Position of this parameter result in the node result'
     field :value, GraphQL::Types::JSON,
-          null: false,
+          null: true,
           description: 'Value returned for this parameter'
 
     id_field ExecutionParameterResult

app/grpc/concerns/grpc_stream_handler.rb

@@ -64,7 +64,7 @@ def self.listen!
           queues&.each do |queue|
             queue << decoded_data
           rescue StandardError => e
-            logger.error(message: 'Error while yielding data', error: e.message)
+            logger.error(message: 'Error while yielding data', error: e.message, backtrace: e.backtrace)
           end
         end
       end

app/grpc/execution_handler.rb

@@ -25,17 +25,18 @@ def test(requests, call)
         ApplicationRecord.connection_pool.with_connection do
           case request.data
           when :logon
-            logger.info(message: 'Execution runtime sent logon', runtime_id: current_runtime_id)
+            logger.info(message: 'Execution runtime sent logon')
           when :response
             handle_execution_result(request.response, current_runtime_id)
           end
         end
       end
     rescue StandardError => e
-      logger.error(message: 'Error reading execution stream', error: e.message, runtime_id: current_runtime_id)
+      logger.error(message: 'Error reading execution stream', error: e.message,
+                   backtrace: e.backtrace)
       outbound_queue << :end if outbound_queue
     ensure
-      logger.info(message: 'Execution runtime request stream closed', runtime_id: current_runtime_id)
+      logger.info(message: 'Execution runtime request stream closed')
     end
 
     enumerator
@@ -81,7 +82,7 @@ def handle_execution_result(execution_result, runtime_id)
       runtime_id: runtime_id,
       execution_identifier: execution_result.execution_identifier,
       error: response.message,
-      details: response.payload
+      details: response.payload.errors.full_messages
     )
   end
 end

app/models/execution_node_result.rb

@@ -23,8 +23,8 @@ def only_one_execution_target_present
   end
 
   def only_one_result_present
-    return if [!success.nil?, !error.nil?].count(true) == 1
+    return if [!success.nil?, !error.nil?].count(true) <= 1
 
-    errors.add(:base, 'Only one of success or error must be present')
+    errors.add(:base, 'Only one of success or error can be present')
   end
 end

app/models/execution_parameter_result.rb

@@ -4,11 +4,4 @@ class ExecutionParameterResult < ApplicationRecord
   belongs_to :execution_node_result, inverse_of: :parameter_results
 
   validates :position, presence: true, numericality: { only_integer: true }
-  validate :value_must_be_present
-
-  private
-
-  def value_must_be_present
-    errors.add(:value, "can't be blank") if value.nil?
-  end
 end

app/models/execution_result.rb

@@ -18,8 +18,8 @@ class ExecutionResult < ApplicationRecord
   private
 
   def only_one_result_present
-    return if [!success.nil?, !error.nil?].count(true) == 1
+    return if [!success.nil?, !error.nil?].count(true) <= 1
 
-    errors.add(:base, 'Only one of success or error must be present')
+    errors.add(:base, 'Only one of success or error can be present')
   end
 end

app/services/namespaces/projects/flows/persist_execution_result_service.rb

@@ -68,7 +68,7 @@ def build_parameter_results(node_record, node_result)
           node_result.parameter_results.each_with_index do |parameter_result, index|
             node_record.parameter_results.build(
               position: index,
-              value: parameter_result.value.to_ruby(true)
+              value: parameter_result.value&.to_ruby(true)
             )
           end
         end

db/migrate/20260612100000_allow_null_execution_result_values.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+class AllowNullExecutionResultValues < Code0::ZeroTrack::Database::Migration[1.0]
+  def change
+    change_column_null :execution_parameter_results, :value, true
+
+    remove_check_constraint :execution_results,
+                            name: check_constraint_name(:execution_results, :result, :at_most_one)
+    add_check_constraint :execution_results,
+                         'num_nonnulls(success, error) <= 1',
+                         name: check_constraint_name(:execution_results, :result, :at_most_one)
+
+    remove_check_constraint :execution_node_results,
+                            name: check_constraint_name(:execution_node_results, :result, :at_most_one)
+    add_check_constraint :execution_node_results,
+                         'num_nonnulls(success, error) <= 1',
+                         name: check_constraint_name(:execution_node_results, :result, :at_most_one)
+  end
+end

db/schema_migrations/20260612100000

@@ -0,0 +1 @@
+2003cd41f9ad43f76b488c0043c3c6b38102fb97a54c7d2de01837bff2d4c36d

db/structure.sql

@@ -194,7 +194,7 @@ CREATE TABLE execution_node_results (
     created_at timestamp with time zone NOT NULL,
     updated_at timestamp with time zone NOT NULL,
     function_definition_id bigint,
-    CONSTRAINT check_26548a5903 CHECK ((num_nonnulls(success, error) = 1))
+    CONSTRAINT check_26548a5903 CHECK ((num_nonnulls(success, error) <= 1))
 );
 
 CREATE SEQUENCE execution_node_results_id_seq
@@ -210,7 +210,7 @@ CREATE TABLE execution_parameter_results (
     id bigint NOT NULL,
     execution_node_result_id bigint NOT NULL,
     "position" integer NOT NULL,
-    value jsonb NOT NULL,
+    value jsonb,
     created_at timestamp with time zone NOT NULL,
     updated_at timestamp with time zone NOT NULL
 );
@@ -236,7 +236,7 @@ CREATE TABLE execution_results (
     created_at timestamp with time zone NOT NULL,
     updated_at timestamp with time zone NOT NULL,
     CONSTRAINT check_1e7a71dfb7 CHECK ((char_length(execution_identifier) <= 200)),
-    CONSTRAINT check_5bf29caaec CHECK ((num_nonnulls(success, error) = 1))
+    CONSTRAINT check_5bf29caaec CHECK ((num_nonnulls(success, error) <= 1))
 );
 
 CREATE SEQUENCE execution_results_id_seq