Fix some identity login issues

Author: Taucher2003

Gemfile

@@ -81,7 +81,7 @@ gem 'rotp'
 gem 'grpc', '~> 1.67'
 gem 'tucana', '0.0.76'
 
-gem 'code0-identities', '~> 0.0.3'
+gem 'code0-identities', '~> 0.0.6'
 
 gem 'pry', '~> 0.16.0'
 gem 'pry-byebug', '~> 3.10'

Gemfile.lock

@@ -89,7 +89,7 @@ GEM
     builder (3.3.0)
     byebug (13.0.0)
       reline (>= 0.6.0)
-    code0-identities (0.0.3)
+    code0-identities (0.0.6)
       base64 (~> 0.3.0)
       httparty (~> 0.22)
       ruby-saml (~> 1.18)
@@ -102,7 +102,7 @@ GEM
     concurrent-ruby (1.3.8)
     connection_pool (3.0.2)
     crass (1.0.7)
-    csv (3.3.5)
+    csv (3.3.6)
     database_cleaner-active_record (2.2.2)
       activerecord (>= 5.a)
       database_cleaner-core (~> 2.0)
@@ -151,7 +151,7 @@ GEM
     grpc (1.83.0)
       google-protobuf (>= 3.25, < 5.0)
       googleapis-common-protos-types (~> 1.0)
-    httparty (0.23.2)
+    httparty (0.24.2)
       csv
       mini_mime (>= 1.0.0)
       multi_xml (>= 0.5.2)
@@ -196,8 +196,8 @@ GEM
       drb (~> 2.0)
       prism (~> 1.5)
     msgpack (1.8.1)
-    multi_xml (0.7.2)
-      bigdecimal (~> 3.1)
+    multi_xml (0.9.1)
+      bigdecimal (>= 3.1, < 5)
     net-imap (0.6.3)
       date
       net-protocol
@@ -625,7 +625,7 @@ DEPENDENCIES
   bcrypt (~> 3.1.7)
   benchmark
   bootsnap
-  code0-identities (~> 0.0.3)
+  code0-identities (~> 0.0.6)
   code0-license (~> 0.3.0)
   code0-zero_track (= 0.0.7)
   database_cleaner-active_record (~> 2.1)

app/graphql/types/identity_provider_type.rb

@@ -8,7 +8,7 @@ class IdentityProviderType < IdentityProviderBasicType
                                                       description: 'Configuration details of the identity provider.'
 
     def config
-      object.config.merge(type: object.type)
+      object[:config].merge(type: object[:type])
     end
   end
 end

app/graphql/types/input/identity_provider_config_input_type.rb

@@ -11,6 +11,8 @@ class IdentityProviderConfigInputType < Types::BaseInputObject
       argument :client_id, String, required: false, description: 'The client ID for the OIDC identity provider'
       argument :client_secret, String, required: false, description: 'The client secret for the OIDC identity provider'
       argument :redirect_uri, String, required: false, description: 'The redirect URI for the OIDC identity provider'
+      argument :token_url, String, required: false,
+                                   description: 'The token URL for the OIDC identity provider'
       argument :user_details_url, String, required: false,
                                           description: 'The user details URL for the OIDC identity provider'
 

app/graphql/types/oidc_identity_provider_config_type.rb

@@ -27,15 +27,23 @@ class OidcIdentityProviderConfigType < Types::BaseObject
           description: 'The name of the OIDC identity provider'
 
     field :user_details_url, String,
-          null: false,
+          null: true,
           description: 'The user details URL for the OIDC identity provider'
 
     field :authorization_url, String,
-          null: false,
+          null: true,
           description: 'The authorization URL for the OIDC identity provider'
 
+    field :token_url, String,
+          null: true,
+          description: 'The token URL for the OIDC identity provider'
+
     field :attribute_statements, GraphQL::Types::JSON,
-          null: false,
+          null: true,
           description: 'List of attribute statements for the OIDC identity provider'
+
+    def provider_name
+      object[:provider_name] || object[:type].downcase
+    end
   end
 end

app/graphql/types/saml_identity_provider_config_type.rb

@@ -13,19 +13,23 @@ class SamlIdentityProviderConfigType < Types::BaseObject
           description: 'The name of the SAML identity provider'
 
     field :attribute_statements, GraphQL::Types::JSON,
-          null: false,
+          null: true,
           description: 'List of attribute statements for the SAML identity provider'
 
     field :settings, GraphQL::Types::JSON,
-          null: false,
+          null: true,
           description: 'The SAML settings for the identity provider'
 
     field :response_settings, GraphQL::Types::JSON,
-          null: false,
+          null: true,
           description: 'The SAML response settings for the identity provider'
 
     field :metadata_url, String,
           null: true,
           description: 'The metadata url to fetch the metadatas (replacement for settings)'
+
+    def provider_name
+      object[:provider_name] || object[:type].downcase
+    end
   end
 end

app/models/application_setting.rb

@@ -65,17 +65,14 @@ def validate_identity_providers
         next errors.add(:value, :id_type_or_config_missing)
       end
 
-      if provider[:type] == 'saml'
-        allowed_keys = %i[provider_name attribute_statements settings response_settings metadata_url]
-        errors.add(:value, :invalid_saml_configuration_keys) unless (provider[:config].keys - allowed_keys).empty?
-      else
-        required_keys = %i[client_id client_secret redirect_uri user_details_url authorization_url]
-        allowed_keys = %i[provider_name attribute_statements] + required_keys
-
-        required_keys -= %i[user_details_url authorization_url] unless provider[:type] == 'oidc'
-
-        errors.add(:value, :invalid_oidc_configuration_keys) unless (provider[:config].keys - allowed_keys).empty?
-        errors.add(:value, :missing_oidc_configuration_keys) unless (required_keys - provider[:config].keys).empty?
+      provider_instance = Code0::Identities::IdentityProvider.for_type(provider[:type]).new(provider[:config].compact)
+
+      begin
+        provider_instance.validate_config!
+      rescue Code0::Identities::MissingConfigurationError
+        errors.add(:value, :missing_identity_provider_config)
+      rescue Code0::Identities::InvalidConfigurationError
+        errors.add(:value, :invalid_identity_provider_config)
       end
     end
   end

app/services/users/identity/base_service.rb

@@ -7,7 +7,7 @@ def identity_provider
         identity_provider = Code0::Identities::IdentityProvider.new
         enabled_providers = ApplicationSetting.current[:identity_providers]
         enabled_providers.each do |provider|
-          provider.deep_symbolize_keys!
+          provider.to_h.deep_symbolize_keys!
           identity_provider.add_named_provider(provider[:id], provider[:type], -> { provider[:config] })
         end
         identity_provider

app/services/users/identity/link_service.rb

@@ -4,6 +4,7 @@ module Users
   module Identity
     class LinkService < BaseService
       include Sagittarius::Database::Transactional
+      include Code0::ZeroTrack::Loggable
 
       attr_reader :current_authentication, :current_user, :provider_id, :args
 
@@ -19,10 +20,13 @@ def execute
         begin
           identity = identity_provider.load_identity(provider_id, args)
         rescue Code0::Identities::Error => e
-          return ServiceResponse.error(payload: e, message: 'An error occurred while loading external identity')
+          logger.warn(message: 'Failed to load external identity', provider_id: provider_id, error: e.message,
+                      backtrace: e.backtrace)
+          return ServiceResponse.error(error_code: :loading_identity_failed,
+                                       message: 'An error occurred while loading external identity')
         end
         if identity.nil?
-          return ServiceResponse.error(payload: :invalid_external_identity, message: 'External identity is nil')
+          return ServiceResponse.error(error_code: :invalid_external_identity, message: 'External identity is nil')
         end
 
         transactional do |t|

docs/graphql/input_object/identityproviderconfiginput.md

@@ -17,4 +17,5 @@ Input for identity provider configuration. Contains fields for both OIDC and SAM
 | `redirectUri` | [`String`](../scalar/string.md) | The redirect URI for the OIDC identity provider |
 | `responseSettings` | [`JSON`](../scalar/json.md) | The SAML response settings for the identity provider |
 | `settings` | [`JSON`](../scalar/json.md) | The SAML settings for the identity provider |
+| `tokenUrl` | [`String`](../scalar/string.md) | The token URL for the OIDC identity provider |
 | `userDetailsUrl` | [`String`](../scalar/string.md) | The user details URL for the OIDC identity provider |