feat: runtime status & function identifer for node executions

Author: raphael-goetz

app/graphql/types/execution_node_result_type.rb

@@ -12,6 +12,9 @@ class ExecutionNodeResultType < Types::BaseObject
     field :finished_at, Types::BigIntType,
           null: false,
           description: 'Unix epoch time in microseconds when this node execution finished'
+    field :function_definition, Types::FunctionDefinitionType,
+          null: true,
+          description: 'Function definition associated with this sub-flow result'
     field :node_function, Types::NodeFunctionType, null: true, description: 'Node function associated with this result'
     field :parameter_results, [Types::ExecutionParameterResultType],
           null: false,

app/graphql/types/runtime_module_definition_type.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module Types
+  class RuntimeModuleDefinitionType < Types::BaseObject
+    description 'A runtime module definition endpoint'
+
+    authorize :read_runtime_module
+
+    field :endpoint, String, null: false, description: 'Endpoint path of the module definition'
+    field :host, String, null: false, description: 'Host of the module definition endpoint'
+    field :port, Types::BigIntType, null: false, description: 'Port of the module definition endpoint'
+
+    id_field RuntimeModuleDefinition
+    timestamps
+  end
+end

app/graphql/types/runtime_module_status_type.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+module Types
+  class RuntimeModuleStatusType < Types::BaseObject
+    description 'A runtime module status information entry'
+
+    authorize :read_runtime_module
+
+    field :last_heartbeat, Types::TimeType,
+          null: true,
+          description: 'The timestamp of the last heartbeat received from the runtime module'
+    field :status, Types::RuntimeStatusStatusEnum,
+          null: false,
+          description: 'The current status of the runtime module',
+          method: :current_status
+    field :uptime, Float,
+          null: false,
+          description: 'Current uptime percentage for the runtime module'
+    field :uptimes, [Float],
+          null: false,
+          description: 'Uptime percentages for the last 14 days'
+
+    id_field RuntimeModuleStatus
+    timestamps
+  end
+end

app/graphql/types/runtime_module_type.rb

@@ -12,6 +12,10 @@ class RuntimeModuleType < Types::BaseObject
           description: 'Configuration definitions of the runtime module',
           method: :module_configuration_definitions
     field :data_types, Types::DataTypeType.connection_type, null: false, description: 'Data types of the runtime module'
+    field :definitions, Types::RuntimeModuleDefinitionType.connection_type,
+          null: false,
+          description: 'Endpoint definitions of the runtime module',
+          method: :runtime_module_definitions
     field :descriptions, [Types::TranslationType], null: true, description: 'Descriptions of the runtime module'
     field :documentation, String, null: false, description: 'Documentation URL of the runtime module'
     field :flow_types, Types::FlowTypeType.connection_type, null: false, description: 'Flow types of the runtime module'
@@ -25,6 +29,10 @@ class RuntimeModuleType < Types::BaseObject
     field :runtime_flow_types, Types::RuntimeFlowTypeType.connection_type,
           null: false,
           description: 'Runtime flow types of the runtime module'
+    field :status, Types::RuntimeModuleStatusType,
+          null: false,
+          description: 'The status of the runtime module',
+          method: :ensure_runtime_module_status!
     # rubocop:disable GraphQL/ExtractType
     field :runtime_function_definitions, Types::RuntimeFunctionDefinitionType.connection_type,
           null: false,

app/graphql/types/runtime_status_status_enum.rb

@@ -4,6 +4,7 @@ module Types
   class RuntimeStatusStatusEnum < Types::BaseEnum
     description 'The enum status of the detailed status'
 
+    value :UNKNOWN, 'The runtime status is unknown', value: 'unknown'
     value :NOT_RESPONDING, 'The runtime is not responding to heartbeats', value: 'not_responding'
     value :NOT_READY, 'The runtime is not ready to compute stuff', value: 'not_ready'
     value :RUNNING, 'The runtime is running and healthy', value: 'running'

app/graphql/types/runtime_status_type.rb

@@ -6,23 +6,19 @@ class RuntimeStatusType < Types::BaseObject
 
     authorize :read_runtime
 
-    field :configurations, Types::RuntimeStatusConfigurationType.connection_type,
-          null: false,
-          description: 'The detailed configuration entries for this runtime status (only for adapters)',
-          method: :runtime_status_configurations
-    field :identifier, String,
-          null: false,
-          description: 'The unique identifier for this runtime status'
     field :last_heartbeat, Types::TimeType,
           null: true,
           description: 'The timestamp of the last heartbeat received from the runtime'
     field :status, Types::RuntimeStatusStatusEnum,
           null: false,
-          description: 'The current status of the runtime (e.g. running, stopped)'
-    field :type, Types::RuntimeStatusTypeEnum,
+          description: 'The current status of the runtime',
+          method: :current_status
+    field :uptime, Float,
+          null: false,
+          description: 'Current uptime percentage for the runtime'
+    field :uptimes, [Float],
           null: false,
-          description: 'The type of runtime status information (e.g. adapter, execution)',
-          method: :status_type
+          description: 'Uptime percentages for the last 14 days'
 
     id_field RuntimeStatus
     timestamps

app/graphql/types/runtime_type.rb

@@ -13,11 +13,8 @@ class RuntimeType < Types::BaseObject
     field :namespace, Types::NamespaceType, null: true, description: 'The parent namespace for the runtime'
     field :projects, Types::NamespaceProjectType.connection_type, null: false,
                                                                   description: 'Projects associated with the runtime'
-    field :status, Types::RuntimeConnectionStatusEnum, null: false, description: 'The status of the runtime'
-
-    field :statuses, Types::RuntimeStatusType.connection_type, null: false,
-                                                               description: 'Statuses of the runtime',
-                                                               method: :runtime_statuses
+    field :status, Types::RuntimeStatusType, null: false, description: 'The status of the runtime',
+                                             method: :ensure_runtime_status!
     field :token, String, null: true, description: 'Token belonging to the runtime, only present on creation'
 
     expose_abilities %i[
@@ -29,17 +26,6 @@ class RuntimeType < Types::BaseObject
     id_field Runtime
     timestamps
 
-    # If the last heartbeat was within the last 10 minutes, consider the runtime as 'running'
-    def status
-      last_heartbeat = object.last_heartbeat
-
-      if last_heartbeat && last_heartbeat >= 10.minutes.ago
-        :connected
-      else
-        :disconnected
-      end
-    end
-
     def token
       object.token if object.token_previously_changed?
     end

app/grpc/runtime_status_handler.rb

@@ -6,14 +6,8 @@ class RuntimeStatusHandler < Tucana::Sagittarius::RuntimeStatusService::Service
 
   def update(request, _call)
     current_runtime = Runtime.find(Code0::ZeroTrack::Context.current[:runtime][:id])
-    status_info = case request.status
-                  when :adapter_runtime_status
-                    request.adapter_runtime_status
-                  when :execution_runtime_status
-                    request.execution_runtime_status
-                  else
-                    return Tucana::Sagittarius::RuntimeStatusUpdateResponse.new(success: false)
-                  end
+    status_info = request.status
+    return Tucana::Sagittarius::RuntimeStatusUpdateResponse.new(success: false) if status_info.nil?
 
     response = Runtimes::Grpc::RuntimeStatusUpdateService.new(
       runtime: current_runtime,

app/models/execution_node_result.rb

@@ -3,17 +3,25 @@
 class ExecutionNodeResult < ApplicationRecord
   belongs_to :execution_result, inverse_of: :node_results
   belongs_to :node_function, optional: true
+  belongs_to :function_definition, optional: true
 
   has_many :parameter_results,
            class_name: 'ExecutionParameterResult',
            inverse_of: :execution_node_result
 
   validates :position, presence: true, numericality: { only_integer: true }
   validates :started_at, :finished_at, numericality: { only_integer: true }
+  validate :only_one_execution_target_present
   validate :only_one_result_present
 
   private
 
+  def only_one_execution_target_present
+    return if [node_function.present?, function_definition.present?].count(true) == 1
+
+    errors.add(:base, 'Only one of node_function or function_definition must be present')
+  end
+
   def only_one_result_present
     return if [!success.nil?, !error.nil?].count(true) == 1
 

app/models/runtime.rb

@@ -7,7 +7,7 @@ class Runtime < ApplicationRecord
 
   token_attr :token, prefix: 's_rt_', length: 48
 
-  has_many :runtime_statuses, inverse_of: :runtime
+  has_one :runtime_status, inverse_of: :runtime
 
   has_many :project_assignments, class_name: 'NamespaceProjectRuntimeAssignment', inverse_of: :runtime
   has_many :projects, class_name: 'NamespaceProject', through: :project_assignments, source: :namespace_project,
@@ -33,11 +33,26 @@ class Runtime < ApplicationRecord
   validates :description, length: { maximum: 500 }, exclusion: { in: [nil] }
 
   before_validation :strip_whitespace
+  after_save :sync_runtime_status_heartbeat!, if: :saved_change_to_last_heartbeat?
+
+  def ensure_runtime_status!
+    runtime_status || create_runtime_status!(
+      last_heartbeat: last_heartbeat,
+      status: RuntimeStatus.status_for_heartbeat(last_heartbeat)
+    )
+  end
 
   private
 
   def strip_whitespace
     name&.strip!
     description&.strip!
   end
+
+  def sync_runtime_status_heartbeat!
+    ensure_runtime_status!.update!(
+      last_heartbeat: last_heartbeat,
+      status: RuntimeStatus.status_for_heartbeat(last_heartbeat)
+    )
+  end
 end