Apply suggestions from code review

Co-authored-by: Niklas van Schrick <mc.taucher2003@gmail.com>
Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>

Author: raphael-goetz

app/policies/user_policy.rb

@@ -3,7 +3,7 @@
 class UserPolicy < BasePolicy
   condition(:user_is_self) { subject.id == user&.id }
   condition(:user_is_admin) { user&.admin? || false }
-  condition(:user_is_regular) { subject.regular? }
+  condition(:subject_is_regular) { subject.regular? }
   condition(:admin_status_visible) { ApplicationSetting.current[:admin_status_visible] }
 
   rule { ~anonymous }.enable :read_user
@@ -13,11 +13,12 @@ class UserPolicy < BasePolicy
     enable :read_user_identity
     enable :update_attachment_avatar
     enable :read_email
+    enable :delete_user
     enable :read_admin_status
     enable :read_mfa_status
   end
 
-  rule { user_is_admin & user_is_regular }.enable :delete_user
+  rule { ~subject_is_regular }.prevent :delete_user
 
   rule { admin_status_visible & ~anonymous }.enable :read_admin_status
 

db/fixtures/02_users.rb

@@ -6,4 +6,5 @@
   u.password = SecureRandom.hex
   u.admin = false
   u.user_type = :ghost
+  u.readme = 'This user will hold the activity of the users that have been deleted'
 end