Merge pull request #1038 from code0-tech/deps/tucana-0-0-75

deps: update Tucana to 0.0.75

Author: Taucher2003

Gemfile

@@ -79,7 +79,7 @@ gem 'good_job', '~> 4.0'
 gem 'rotp'
 
 gem 'grpc', '~> 1.67'
-gem 'tucana', '0.0.74'
+gem 'tucana', '0.0.75'
 
 gem 'code0-identities', '~> 0.0.3'
 

Gemfile.lock

@@ -390,7 +390,7 @@ GEM
       open3 (~> 0.2)
       tucana (~> 0.0, >= 0.0.72)
     tsort (0.2.0)
-    tucana (0.0.74)
+    tucana (0.0.75)
       grpc (~> 1.64)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
@@ -446,7 +446,7 @@ DEPENDENCIES
   simplecov-cobertura (~> 3.0)
   test-prof (~> 1.0)
   triangulum (= 0.22.0)
-  tucana (= 0.0.74)
+  tucana (= 0.0.75)
   tzinfo-data
 
 RUBY VERSION

app/services/namespaces/projects/flows/persist_execution_result_service.rb

@@ -56,7 +56,7 @@ def build_node_results(result)
               started_at: node_result.started_at,
               finished_at: node_result.finished_at,
               node_function: node_function_for(node_result),
-              function_definition: function_definition_for(node_result)
+              function_definition: function_definition_for(node_result, result.flow)
             )
 
             assign_result(node_record, node_result)
@@ -79,10 +79,10 @@ def node_function_for(node_result)
           NodeFunction.find_by(id: node_result.node_id)
         end
 
-        def function_definition_for(node_result)
-          return unless node_result.id == :function_id
+        def function_definition_for(node_result, flow)
+          return unless node_result.id == :function_identifier
 
-          FunctionDefinition.find_by(id: node_result.function_id)
+          FunctionDefinition.find_by(runtime: flow.project.primary_runtime, identifier: node_result.function_identifier)
         end
 
         def assign_result(record, grpc_record)

spec/services/namespaces/projects/flows/persist_execution_result_service_spec.rb

@@ -168,6 +168,7 @@
 
   context 'when a node execution result targets a function definition' do
     let(:function_definition) { create(:function_definition) }
+
     let(:grpc_result) do
       Tucana::Shared::ExecutionResult.new(
         execution_identifier: 'execution-identifier',
@@ -178,7 +179,7 @@
         success: Tucana::Shared::Value.from_ruby('result' => true),
         node_execution_results: [
           Tucana::Shared::NodeExecutionResult.new(
-            function_id: function_definition.id,
+            function_identifier: function_definition.identifier,
             started_at: started_at,
             finished_at: finished_at,
             success: Tucana::Shared::Value.from_ruby('function' => 'ok')
@@ -187,6 +188,10 @@
       )
     end
 
+    before do
+      flow.project.update!(primary_runtime: function_definition.runtime)
+    end
+
     it 'persists the function definition as the execution target' do
       expect(service_response).to be_success
 
@@ -196,6 +201,14 @@
         success: { 'function' => 'ok' }
       )
     end
+
+    it 'ignores matching definitions from other runtimes' do
+      expect(service_response).to be_success
+
+      expect(service_response.payload.node_results.sole).to have_attributes(
+        function_definition: function_definition
+      )
+    end
   end
 
   context 'when the result is an error' do