feat: added authorization to velorum query object

Author: raphael-goetz

app/graphql/types/query_type.rb

@@ -43,7 +43,7 @@ class QueryType < Types::BaseObject
     field :users, Types::UserType.connection_type, null: false, description: 'Find users'
 
     field :global_runtimes, Types::RuntimeType.connection_type, null: false, description: 'Find runtimes'
-    field :velorum, Types::VelorumType, null: false, description: 'Get Velorum information'
+    field :velorum, Types::VelorumType, null: true, description: 'Get Velorum information'
 
     def application
       {}

app/graphql/types/velorum_type.rb

@@ -4,6 +4,9 @@ module Types
   class VelorumType < Types::BaseObject
     description 'Represents Velorum integration information'
 
+    authorize :read_velorum_config
+    declarative_policy_subject { :global }
+
     field :enabled, Boolean, null: false, description: 'Whether Velorum is enabled'
     field :models, [Types::VelorumModelType], null: false, description: 'Find models available through Velorum'
 

app/policies/global_policy.rb

@@ -12,6 +12,7 @@ class GlobalPolicy < BasePolicy
     enable :read_flow_type
     enable :read_flow_type_setting
     enable :read_metadata
+    enable :read_velorum_config
   end
 
   rule { admin }.policy do

docs/graphql/object/query.md

@@ -14,7 +14,7 @@ Root Query type
 | `globalRuntimes` | [`RuntimeConnection!`](../object/runtimeconnection.md) | Find runtimes |
 | `organizations` | [`OrganizationConnection!`](../object/organizationconnection.md) | Find organizations |
 | `users` | [`UserConnection!`](../object/userconnection.md) | Find users |
-| `velorum` | [`Velorum!`](../object/velorum.md) | Get Velorum information |
+| `velorum` | [`Velorum`](../object/velorum.md) | Get Velorum information |
 
 ## Fields with arguments
 

spec/graphql/types/velorum_type_spec.rb

@@ -12,4 +12,5 @@
 
   it { expect(described_class.graphql_name).to eq('Velorum') }
   it { expect(described_class).to have_graphql_fields(fields) }
+  it { expect(described_class).to require_graphql_authorizations(:read_velorum_config) }
 end

spec/requests/graphql/query/velorum_query_spec.rb

@@ -21,6 +21,7 @@
     QUERY
   end
 
+  let(:current_user) { create(:user) }
   let(:client) { instance_double(Sagittarius::Velorum::Client) }
   let(:models_response) do
     Tucana::Velorum::ModelsResponse.new(
@@ -49,7 +50,7 @@
   end
 
   it 'proxies models from Velorum through gRPC' do
-    post_graphql(query)
+    post_graphql(query, current_user: current_user)
 
     expect(graphql_data_at(:velorum, :enabled)).to be(true)
     expect(graphql_data_at(:velorum, :models)).to contain_exactly(
@@ -76,7 +77,7 @@
     end
 
     it 'returns disabled state and an empty model list without creating a Velorum client' do
-      post_graphql(query)
+      post_graphql(query, current_user: current_user)
 
       expect(graphql_data_at(:velorum, :enabled)).to be(false)
       expect(graphql_data_at(:velorum, :models)).to eq([])