Merge pull request #1026 from code0-tech/#1023-function-identifier-to-execution-result

function identifier to execution result & runtime module definition

Author: raphael-goetz

Gemfile

@@ -79,7 +79,7 @@ gem 'good_job', '~> 4.0'
 gem 'rotp'
 
 gem 'grpc', '~> 1.67'
-gem 'tucana', '0.0.73'
+gem 'tucana', '0.0.74'
 
 gem 'code0-identities', '~> 0.0.3'
 

Gemfile.lock

@@ -390,7 +390,7 @@ GEM
       open3 (~> 0.2)
       tucana (~> 0.0, >= 0.0.72)
     tsort (0.2.0)
-    tucana (0.0.73)
+    tucana (0.0.74)
       grpc (~> 1.64)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
@@ -446,7 +446,7 @@ DEPENDENCIES
   simplecov-cobertura (~> 3.0)
   test-prof (~> 1.0)
   triangulum (= 0.21.0)
-  tucana (= 0.0.73)
+  tucana (= 0.0.74)
   tzinfo-data
 
 RUBY VERSION

app/graphql/types/execution_node_result_type.rb

@@ -12,6 +12,9 @@ class ExecutionNodeResultType < Types::BaseObject
     field :finished_at, Types::BigIntType,
           null: false,
           description: 'Unix epoch time in microseconds when this node execution finished'
+    field :function_definition, Types::FunctionDefinitionType,
+          null: true,
+          description: 'Function definition associated with this sub-flow result'
     field :node_function, Types::NodeFunctionType, null: true, description: 'Node function associated with this result'
     field :parameter_results, [Types::ExecutionParameterResultType],
           null: false,

app/graphql/types/runtime_module_definition_type.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module Types
+  class RuntimeModuleDefinitionType < Types::BaseObject
+    description 'A runtime module definition endpoint'
+
+    authorize :read_runtime_module
+
+    field :endpoint, String, null: false, description: 'Endpoint path of the module definition'
+    field :host, String, null: false, description: 'Host of the module definition endpoint'
+    field :port, Types::BigIntType, null: false, description: 'Port of the module definition endpoint'
+
+    id_field RuntimeModuleDefinition
+    timestamps
+  end
+end

app/graphql/types/runtime_module_type.rb

@@ -12,6 +12,10 @@ class RuntimeModuleType < Types::BaseObject
           description: 'Configuration definitions of the runtime module',
           method: :module_configuration_definitions
     field :data_types, Types::DataTypeType.connection_type, null: false, description: 'Data types of the runtime module'
+    field :definitions, Types::RuntimeModuleDefinitionType.connection_type,
+          null: false,
+          description: 'Definitions of the runtime module',
+          method: :runtime_module_definitions
     field :descriptions, [Types::TranslationType], null: true, description: 'Descriptions of the runtime module'
     field :documentation, String, null: false, description: 'Documentation URL of the runtime module'
     field :flow_types, Types::FlowTypeType.connection_type, null: false, description: 'Flow types of the runtime module'

app/graphql/types/runtime_status_type.rb

@@ -5,7 +5,6 @@ class RuntimeStatusType < Types::BaseObject
     description 'A runtime status information entry'
 
     authorize :read_runtime
-
     field :configurations, Types::RuntimeStatusConfigurationType.connection_type,
           null: false,
           description: 'The detailed configuration entries for this runtime status (only for adapters)',
@@ -18,10 +17,10 @@ class RuntimeStatusType < Types::BaseObject
           description: 'The timestamp of the last heartbeat received from the runtime'
     field :status, Types::RuntimeStatusStatusEnum,
           null: false,
-          description: 'The current status of the runtime (e.g. running, stopped)'
-    field :type, Types::RuntimeStatusTypeEnum,
+          description: 'The current status of the runtime'
+    field :type, RuntimeStatusTypeEnum,
           null: false,
-          description: 'The type of runtime status information (e.g. adapter, execution)',
+          description: 'Type of the runtime status',
           method: :status_type
 
     id_field RuntimeStatus

app/grpc/runtime_status_handler.rb

@@ -4,16 +4,11 @@ class RuntimeStatusHandler < Tucana::Sagittarius::RuntimeStatusService::Service
   include Code0::ZeroTrack::Loggable
   include GrpcHandler
 
-  def update(request, _call)
+  # TODO: Implement in #1018
+  def update_disabled(request, _call)
     current_runtime = Runtime.find(Code0::ZeroTrack::Context.current[:runtime][:id])
-    status_info = case request.status
-                  when :adapter_runtime_status
-                    request.adapter_runtime_status
-                  when :execution_runtime_status
-                    request.execution_runtime_status
-                  else
-                    return Tucana::Sagittarius::RuntimeStatusUpdateResponse.new(success: false)
-                  end
+    status_info = request.status
+    return Tucana::Sagittarius::RuntimeStatusUpdateResponse.new(success: false) if status_info.nil?
 
     response = Runtimes::Grpc::RuntimeStatusUpdateService.new(
       runtime: current_runtime,

app/models/execution_node_result.rb

@@ -3,17 +3,25 @@
 class ExecutionNodeResult < ApplicationRecord
   belongs_to :execution_result, inverse_of: :node_results
   belongs_to :node_function, optional: true
+  belongs_to :function_definition, optional: true
 
   has_many :parameter_results,
            class_name: 'ExecutionParameterResult',
            inverse_of: :execution_node_result
 
   validates :position, presence: true, numericality: { only_integer: true }
   validates :started_at, :finished_at, numericality: { only_integer: true }
+  validate :only_one_execution_target_present
   validate :only_one_result_present
 
   private
 
+  def only_one_execution_target_present
+    return if [node_function.present?, function_definition.present?].count(true) == 1
+
+    errors.add(:base, 'Only one of node_function or function_definition must be present')
+  end
+
   def only_one_result_present
     return if [!success.nil?, !error.nil?].count(true) == 1
 

app/models/runtime_module.rb

@@ -11,6 +11,7 @@ class RuntimeModule < ApplicationRecord
   has_many :runtime_function_definitions, inverse_of: :runtime_module
   has_many :function_definitions, inverse_of: :runtime_module
   has_many :module_configuration_definitions, inverse_of: :runtime_module
+  has_many :runtime_module_definitions, inverse_of: :runtime_module
 
   has_translation :names, purpose: :name
   has_translation :descriptions, purpose: :description

app/models/runtime_module_definition.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+class RuntimeModuleDefinition < ApplicationRecord
+  belongs_to :runtime_module, inverse_of: :runtime_module_definitions
+
+  validates :host, presence: true, length: { maximum: 253 }
+  validates :endpoint, presence: true, length: { maximum: 2048 }
+  validates :port, numericality: { only_integer: true, greater_than_or_equal_to: 0, less_than_or_equal_to: 65_535 }
+end