fix: always use primary runtime

Author: raphael-goetz

app/grpc/execution_handler.rb

@@ -74,10 +74,7 @@ def handle_execution_result(execution_result, runtime_id)
       execution_identifier: execution_result.execution_identifier
     )
 
-    response = Namespaces::Projects::Flows::PersistExecutionResultService.new(
-      execution_result,
-      runtime_id: runtime_id
-    ).execute
+    response = Namespaces::Projects::Flows::PersistExecutionResultService.new(execution_result).execute
     return if response.success?
 
     logger.error(

app/services/namespaces/projects/flows/persist_execution_result_service.rb

@@ -6,11 +6,10 @@ module Flows
       class PersistExecutionResultService
         include Code0::ZeroTrack::Loggable
 
-        attr_reader :grpc_result, :runtime_id
+        attr_reader :grpc_result
 
-        def initialize(grpc_result, runtime_id: nil)
+        def initialize(grpc_result)
           @grpc_result = grpc_result
-          @runtime_id = runtime_id
         end
 
         def execute
@@ -83,16 +82,7 @@ def node_function_for(node_result)
         def function_definition_for(node_result, flow)
           return unless node_result.id == :function_identifier
 
-          runtime = runtime_for(flow)
-          return if runtime.nil?
-
-          FunctionDefinition.find_by(runtime: runtime, identifier: node_result.function_identifier)
-        end
-
-        def runtime_for(flow)
-          return Runtime.find_by(id: runtime_id) if runtime_id.present?
-
-          flow.project.primary_runtime || flow.flow_type.runtime
+          FunctionDefinition.find_by(runtime: flow.project.primary_runtime, identifier: node_result.function_identifier)
         end
 
         def assign_result(record, grpc_record)

spec/services/namespaces/projects/flows/persist_execution_result_service_spec.rb

@@ -3,11 +3,10 @@
 require 'rails_helper'
 
 RSpec.describe Namespaces::Projects::Flows::PersistExecutionResultService do
-  subject(:service_response) { described_class.new(grpc_result, runtime_id: runtime_id).execute }
+  subject(:service_response) { described_class.new(grpc_result).execute }
 
   let(:flow) { create(:flow) }
   let(:node_function) { create(:node_function, flow: flow) }
-  let(:runtime_id) { nil }
   let(:started_at) { 1_780_430_000_000_000 }
   let(:finished_at) { 1_780_430_002_000_000 }
 
@@ -169,9 +168,6 @@
 
   context 'when a node execution result targets a function definition' do
     let(:function_definition) { create(:function_definition) }
-    let!(:other_function_definition) do
-      create(:function_definition, identifier: function_definition.identifier)
-    end
 
     let(:grpc_result) do
       Tucana::Shared::ExecutionResult.new(
@@ -206,16 +202,12 @@
       )
     end
 
-    context 'when a runtime id is provided' do
-      let(:runtime_id) { other_function_definition.runtime_id }
-
-      it 'looks up the function definition in the connected runtime' do
-        expect(service_response).to be_success
+    it 'ignores matching definitions from other runtimes' do
+      expect(service_response).to be_success
 
-        expect(service_response.payload.node_results.sole).to have_attributes(
-          function_definition: other_function_definition
-        )
-      end
+      expect(service_response.payload.node_results.sole).to have_attributes(
+        function_definition: function_definition
+      )
     end
   end