feat: removed runtime status impl

Author: raphael-goetz

app/graphql/types/runtime_module_status_type.rb

@@ -14,7 +14,7 @@ class RuntimeModuleType < Types::BaseObject
     field :data_types, Types::DataTypeType.connection_type, null: false, description: 'Data types of the runtime module'
     field :definitions, Types::RuntimeModuleDefinitionType.connection_type,
           null: false,
-          description: 'Endpoint definitions of the runtime module',
+          description: 'Definitions of the runtime module',
           method: :runtime_module_definitions
     field :descriptions, [Types::TranslationType], null: true, description: 'Descriptions of the runtime module'
     field :documentation, String, null: false, description: 'Documentation URL of the runtime module'
@@ -29,10 +29,6 @@ class RuntimeModuleType < Types::BaseObject
     field :runtime_flow_types, Types::RuntimeFlowTypeType.connection_type,
           null: false,
           description: 'Runtime flow types of the runtime module'
-    field :status, Types::RuntimeModuleStatusType,
-          null: false,
-          description: 'The status of the runtime module',
-          method: :ensure_runtime_module_status!
     # rubocop:disable GraphQL/ExtractType
     field :runtime_function_definitions, Types::RuntimeFunctionDefinitionType.connection_type,
           null: false,

app/graphql/types/runtime_module_type.rb

@@ -4,7 +4,6 @@ module Types
   class RuntimeStatusStatusEnum < Types::BaseEnum
     description 'The enum status of the detailed status'
 
-    value :UNKNOWN, 'The runtime status is unknown', value: 'unknown'
     value :NOT_RESPONDING, 'The runtime is not responding to heartbeats', value: 'not_responding'
     value :NOT_READY, 'The runtime is not ready to compute stuff', value: 'not_ready'
     value :RUNNING, 'The runtime is running and healthy', value: 'running'

app/graphql/types/runtime_status_status_enum.rb

@@ -5,20 +5,24 @@ class RuntimeStatusType < Types::BaseObject
     description 'A runtime status information entry'
 
     authorize :read_runtime
-
+    field :configurations, Types::RuntimeStatusConfigurationType.connection_type,
+          null: false,
+          description: 'The detailed configuration entries for this runtime status (only for adapters)',
+          method: :runtime_status_configurations
+    field :identifier, String,
+          null: false,
+          description: 'The unique identifier for this runtime status'
     field :last_heartbeat, Types::TimeType,
           null: true,
           description: 'The timestamp of the last heartbeat received from the runtime'
     field :status, Types::RuntimeStatusStatusEnum,
           null: false,
           description: 'The current status of the runtime',
           method: :current_status
-    field :uptime, Float,
-          null: false,
-          description: 'Current uptime percentage for the runtime'
-    field :uptimes, [Float],
+    field :type, RuntimeStatusTypeEnum,
           null: false,
-          description: 'Uptime percentages for the last 14 days'
+          description: 'Type of the runtime status',
+          method: :status_type
 
     id_field RuntimeStatus
     timestamps

app/graphql/types/runtime_status_type.rb

@@ -13,8 +13,11 @@ class RuntimeType < Types::BaseObject
     field :namespace, Types::NamespaceType, null: true, description: 'The parent namespace for the runtime'
     field :projects, Types::NamespaceProjectType.connection_type, null: false,
                                                                   description: 'Projects associated with the runtime'
-    field :status, Types::RuntimeStatusType, null: false, description: 'The status of the runtime',
-                                             method: :ensure_runtime_status!
+    field :status, Types::RuntimeConnectionStatusEnum, null: false, description: 'The status of the runtime'
+
+    field :statuses, Types::RuntimeStatusType.connection_type, null: false,
+                                                               description: 'Statuses of the runtime',
+                                                               method: :runtime_statuses
     field :token, String, null: true, description: 'Token belonging to the runtime, only present on creation'
 
     expose_abilities %i[
@@ -26,6 +29,17 @@ class RuntimeType < Types::BaseObject
     id_field Runtime
     timestamps
 
+    # If the last heartbeat was within the last 10 minutes, consider the runtime as 'running'
+    def status
+      last_heartbeat = object.last_heartbeat
+
+      if last_heartbeat && last_heartbeat >= 10.minutes.ago
+        :connected
+      else
+        :disconnected
+      end
+    end
+
     def token
       object.token if object.token_previously_changed?
     end

app/graphql/types/runtime_type.rb

@@ -4,7 +4,8 @@ class RuntimeStatusHandler < Tucana::Sagittarius::RuntimeStatusService::Service
   include Code0::ZeroTrack::Loggable
   include GrpcHandler
 
-  def update(request, _call)
+  # TODO: Implement in #1018
+  def update_disabled(request, _call)
     current_runtime = Runtime.find(Code0::ZeroTrack::Context.current[:runtime][:id])
     status_info = request.status
     return Tucana::Sagittarius::RuntimeStatusUpdateResponse.new(success: false) if status_info.nil?

app/grpc/runtime_status_handler.rb

@@ -7,7 +7,7 @@ class Runtime < ApplicationRecord
 
   token_attr :token, prefix: 's_rt_', length: 48
 
-  has_one :runtime_status, inverse_of: :runtime
+  has_many :runtime_statuses, inverse_of: :runtime
 
   has_many :project_assignments, class_name: 'NamespaceProjectRuntimeAssignment', inverse_of: :runtime
   has_many :projects, class_name: 'NamespaceProject', through: :project_assignments, source: :namespace_project,
@@ -33,26 +33,11 @@ class Runtime < ApplicationRecord
   validates :description, length: { maximum: 500 }, exclusion: { in: [nil] }
 
   before_validation :strip_whitespace
-  after_save :sync_runtime_status_heartbeat!, if: :saved_change_to_last_heartbeat?
-
-  def ensure_runtime_status!
-    runtime_status || create_runtime_status!(
-      last_heartbeat: last_heartbeat,
-      status: RuntimeStatus.status_for_heartbeat(last_heartbeat)
-    )
-  end
 
   private
 
   def strip_whitespace
     name&.strip!
     description&.strip!
   end
-
-  def sync_runtime_status_heartbeat!
-    ensure_runtime_status!.update!(
-      last_heartbeat: last_heartbeat,
-      status: RuntimeStatus.status_for_heartbeat(last_heartbeat)
-    )
-  end
 end

app/models/runtime.rb

@@ -12,7 +12,6 @@ class RuntimeModule < ApplicationRecord
   has_many :function_definitions, inverse_of: :runtime_module
   has_many :module_configuration_definitions, inverse_of: :runtime_module
   has_many :runtime_module_definitions, inverse_of: :runtime_module
-  has_one :runtime_module_status, inverse_of: :runtime_module
 
   has_translation :names, purpose: :name
   has_translation :descriptions, purpose: :description
@@ -26,10 +25,6 @@ class RuntimeModule < ApplicationRecord
 
   validate :validate_version
 
-  def ensure_runtime_module_status!
-    runtime_module_status || create_runtime_module_status!(status: :unknown)
-  end
-
   def validate_version
     return errors.add(:version, :blank) if version.blank?
 

app/models/runtime_module.rb

@@ -4,5 +4,5 @@ class RuntimeModuleDefinition < ApplicationRecord
   belongs_to :runtime_module, inverse_of: :runtime_module_definitions
 
   validates :host, :endpoint, presence: true
-  validates :port, numericality: { only_integer: true, greater_than_or_equal_to: 0 }
+  validates :port, numericality: { only_integer: true, greater_than_or_equal_to: 0, less_than_or_equal_to: 65_535 }
 end