Merge pull request #1034 from code0-tech/fix-module-definition-update

Fix update of runtime module definitions

Author: Taucher2003

app/models/runtime_module_definition.rb

@@ -6,4 +6,8 @@ class RuntimeModuleDefinition < ApplicationRecord
   validates :host, presence: true, length: { maximum: 253 }
   validates :endpoint, presence: true, length: { maximum: 2048 }
   validates :port, numericality: { only_integer: true, greater_than_or_equal_to: 0, less_than_or_equal_to: 65_535 }
+
+  def nilify_attributes!(except = %w[id runtime_module_id created_at updated_at])
+    attribute_names.reject { |attr| except.include?(attr) }.each { |attr| self[attr] = nil }
+  end
 end

app/services/runtimes/grpc/modules/update_service.rb

@@ -112,26 +112,31 @@ def update_definition_services(module_records, t)
         def update_module_definitions(module_records, t)
           modules.each do |grpc_module|
             runtime_module = module_records.fetch(grpc_module)
-            runtime_module.runtime_module_definitions.delete_all
+            db_module_definitions = runtime_module.runtime_module_definitions.first(grpc_module.definitions.length)
 
-            grpc_module.definitions.each do |definition|
+            grpc_module.definitions.each_with_index do |definition, index|
               next unless definition.value == :endpoint
 
               endpoint = definition.endpoint
-              module_definition = runtime_module.runtime_module_definitions.build(
+              db_module_definitions[index] ||= runtime_module.runtime_module_definitions.build
+              db_module_definitions[index].nilify_attributes!
+
+              db_module_definitions[index].assign_attributes(
                 host: endpoint.host,
                 port: endpoint.port,
                 endpoint: endpoint.endpoint
               )
 
-              next if module_definition.save
+              next if db_module_definitions[index].save
 
               t.rollback_and_return! ServiceResponse.error(
                 message: 'Failed to update runtime module definition',
                 error_code: :invalid_runtime_module_definition,
-                details: module_definition.errors
+                details: db_module_definitions[index].errors
               )
             end
+
+            runtime_module.runtime_module_definitions.excluding(db_module_definitions).delete_all
           end
         end