From 2278d995e0b60caaa8974fc5e4773e78b07b7e8c Mon Sep 17 00:00:00 2001 From: Niklas van Schrick Date: Sun, 26 Jul 2026 01:27:47 +0200 Subject: [PATCH] Improve logging for failed module updates --- app/grpc/module_handler.rb | 8 +++++++- app/services/runtimes/grpc/modules/update_service.rb | 4 ++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/app/grpc/module_handler.rb b/app/grpc/module_handler.rb index edcafacc8..6ca2c8c08 100644 --- a/app/grpc/module_handler.rb +++ b/app/grpc/module_handler.rb @@ -11,9 +11,15 @@ def update(request, _call) logger.debug("ModuleHandler#update response: #{response.inspect}") unless response.success? + details = if response.payload[:details].is_a?(ActiveModel::Errors) + { error_code: response.payload[:error_code], details: response.payload[:details].full_messages } + else + response.payload + end + logger.warn(message: 'Failed to update modules', error: response.message, - details: response.payload) + details: details) end response.to_grpc_response(Tucana::Sagittarius::ModuleUpdateResponse) diff --git a/app/services/runtimes/grpc/modules/update_service.rb b/app/services/runtimes/grpc/modules/update_service.rb index 59344ac32..dd1e726a8 100644 --- a/app/services/runtimes/grpc/modules/update_service.rb +++ b/app/services/runtimes/grpc/modules/update_service.rb @@ -133,6 +133,10 @@ def update_module_definitions(module_records, t) next if db_module_definitions[index].save + logger.error(message: 'Failed to update runtime module definition', + module_identifier: grpc_module.identifier, + errors: db_module_definitions[index].errors.full_messages) + t.rollback_and_return! ServiceResponse.error( message: 'Failed to update runtime module definition', error_code: :invalid_runtime_module_definition,