Skip to content

Improve logging for failed module updates #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Taucher2003 merged 1 commit into from
Jul 25, 2026
Merged

Improve logging for failed module updates #1165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/grpc/module_handler.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,15 @@ def update(request, _call)

logger.debug("ModuleHandler#update response: #{response.inspect}")
unless response.success?
details = if response.payload[:details].is_a?(ActiveModel::Errors)
{ error_code: response.payload[:error_code], details: response.payload[:details].full_messages }
else
response.payload
end

logger.warn(message: 'Failed to update modules',
error: response.message,
details: response.payload)
details: details)
end

response.to_grpc_response(Tucana::Sagittarius::ModuleUpdateResponse)
Expand Down
4 changes: 4 additions & 0 deletions app/services/runtimes/grpc/modules/update_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,10 @@ def update_module_definitions(module_records, t)

next if db_module_definitions[index].save

logger.error(message: 'Failed to update runtime module definition',
module_identifier: grpc_module.identifier,
errors: db_module_definitions[index].errors.full_messages)

t.rollback_and_return! ServiceResponse.error(
message: 'Failed to update runtime module definition',
error_code: :invalid_runtime_module_definition,
Expand Down