fix: address reviewer feedback on undefined providers and misleading fallbacks

Agent-Logs-Url: https://github.com/code0-tech/sculptor/sessions/048cca08-92f4-4fa2-8a78-2b41441cbd7a

Co-authored-by: nicosammito <60352747+nicosammito@users.noreply.github.com>

Author: Copilot

src/instrumentation-client.ts

@@ -4,9 +4,8 @@ import initializeTraces, {openTelemetryClientTracesProvider} from "@core/util/op
 import {logs} from "@opentelemetry/api-logs"
 import {trace} from "@opentelemetry/api"
 
-if (process.env)
 initializeLogs("client")
-logs.setGlobalLoggerProvider(openTelemetryClientLogsProvider)
+if (openTelemetryClientLogsProvider) logs.setGlobalLoggerProvider(openTelemetryClientLogsProvider)
 
 initializeTraces("client")
-trace.setGlobalTracerProvider(openTelemetryClientTracesProvider)
+if (openTelemetryClientTracesProvider) trace.setGlobalTracerProvider(openTelemetryClientTracesProvider)

src/instrumentation.ts

@@ -6,17 +6,15 @@ import initializeTraces, {openTelemetryServerTracesProvider} from "@core/util/op
 
 export function register() {
 
-
-    metrics.setGlobalMeterProvider(openTelemetryMetricProvider)
+    if (openTelemetryMetricProvider) metrics.setGlobalMeterProvider(openTelemetryMetricProvider)
     initializeMetrics()
 
-    logs.setGlobalLoggerProvider(openTelemetryServerLogsProvider)
+    if (openTelemetryServerLogsProvider) logs.setGlobalLoggerProvider(openTelemetryServerLogsProvider)
     initializeLogs()
 
-    trace.setGlobalTracerProvider(openTelemetryServerTracesProvider)
+    if (openTelemetryServerTracesProvider) trace.setGlobalTracerProvider(openTelemetryServerTracesProvider)
     initializeTraces()
 
-
 }
 
 

src/packages/core/src/util/open-telemetry.ts

@@ -1,13 +1,13 @@
 import {resourceFromAttributes} from "@opentelemetry/resources";
 
 export const resource = resourceFromAttributes({
-    'service.name': process.env.NEXT_PUBLIC_OTEL_SERVICE_NAME || "service.name",
+    ...(process.env.NEXT_PUBLIC_OTEL_SERVICE_NAME ? {'service.name': process.env.NEXT_PUBLIC_OTEL_SERVICE_NAME} : {}),
     'service.version': (process.env.NEXT_PUBLIC_SCULPTOR_VERSION ?? "0.0.0") + "-" + (process.env.NEXT_PUBLIC_EDITION ?? "edition"),
-    'deployment.environment.name': process.env.NEXT_PUBLIC_OTEL_ENVIRONMENT || "deployment.environment.name",
+    ...(process.env.NEXT_PUBLIC_OTEL_ENVIRONMENT ? {'deployment.environment.name': process.env.NEXT_PUBLIC_OTEL_ENVIRONMENT} : {}),
 });
 
 export const serverResource = resourceFromAttributes({
-    'service.name': process.env.OTEL_SERVICE_NAME || "service.name",
+    ...(process.env.OTEL_SERVICE_NAME ? {'service.name': process.env.OTEL_SERVICE_NAME} : {}),
     'service.version': (process.env.NEXT_PUBLIC_SCULPTOR_VERSION ?? "0.0.0") + "-" + (process.env.NEXT_PUBLIC_EDITION ?? "edition"),
-    'deployment.environment.name': process.env.NEXT_PUBLIC_OTEL_ENVIRONMENT || "deployment.environment.name",
+    ...(process.env.NEXT_PUBLIC_OTEL_ENVIRONMENT ? {'deployment.environment.name': process.env.NEXT_PUBLIC_OTEL_ENVIRONMENT} : {}),
 });