Skip to content

Commit 11d5856

Browse files
committed
feat: enhance ModuleConfigurationPage layout and improve user feedback on configuration copy
1 parent cbb60e4 commit 11d5856

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

src/packages/ce/src/module/pages/ModuleConfigurationPage.tsx

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ export const ModuleConfigurationPage: React.FC = () => {
171171
</div>
172172
})
173173
}
174-
<Panel position={"bottom-center"}>
174+
<Panel position={"bottom-center"} style={{bottom: "1.3rem"}}>
175175
<ButtonGroup>
176176
<Select key={runtime?.id}
177177
value={runtime?.id as string}
@@ -189,7 +189,7 @@ export const ModuleConfigurationPage: React.FC = () => {
189189
</Button>
190190
</SelectTrigger>
191191
<SelectPortal>
192-
<SelectContent>
192+
<SelectContent side={"top"} sideOffset={8} position={"popper"}>
193193
<SelectViewport>
194194
{
195195
runtimes.map(runtime => {
@@ -202,6 +202,9 @@ export const ModuleConfigurationPage: React.FC = () => {
202202
<Text>
203203
{runtime.name}
204204
</Text>
205+
{runtime.id === project?.primaryRuntime?.id && <Badge color={"secondary"}>
206+
Primary
207+
</Badge>}
205208
</Flex>
206209
</SelectItemText>
207210
</SelectItem>
@@ -219,7 +222,7 @@ export const ModuleConfigurationPage: React.FC = () => {
219222
</Button>
220223
</MenuTrigger>
221224
<MenuPortal>
222-
<MenuContent>
225+
<MenuContent side={"top"} sideOffset={8}>
223226
{
224227
runtimes.map(pRuntime => {
225228
return <MenuItem onSelect={() => {
@@ -243,7 +246,7 @@ export const ModuleConfigurationPage: React.FC = () => {
243246
}).then(payload => {
244247
if ((payload?.errors?.length ?? 0) <= 0) {
245248
toast({
246-
title: "Copied configuration",
249+
title: "Copied and saved configuration",
247250
color: "success",
248251
dismissible: true,
249252
})
@@ -260,6 +263,9 @@ export const ModuleConfigurationPage: React.FC = () => {
260263
<Text>
261264
{pRuntime.name}
262265
</Text>
266+
{pRuntime.id === project?.primaryRuntime?.id && <Badge color={"secondary"}>
267+
Primary
268+
</Badge>}
263269
</Flex>
264270
</MenuItem>
265271
})

0 commit comments

Comments
 (0)