feat: improve parameter index handling in FunctionFileDefaultComponent and FunctionSuggestion hook

Author: nicosammito

src/packages/ce/src/function/components/files/FunctionFileDefaultComponent.tsx

@@ -64,7 +64,7 @@ export const FunctionFileDefaultComponent: React.FC<FunctionFileDefaultComponent
         startTransition(async () => {
             for (const parameterDefinition of definition?.parameterDefinitions!) {
                 const parameterIndex = definition?.parameterDefinitions?.findIndex(p => p?.id === parameterDefinition.id)
-                if (!parameterIndex) return
+                if (typeof parameterIndex !== "number") return
                 if (!changedParameters.current.has(parameterIndex)) continue;
                 const nodeParameter = node.parameters?.nodes?.find(p => p?.parameterDefinition?.id === parameterDefinition.id)
                 const syntaxSegment = values[parameterIndex]
@@ -121,8 +121,6 @@ export const FunctionFileDefaultComponent: React.FC<FunctionFileDefaultComponent
 
             if (!parameterDefinition) return null
 
-            const nodeParameter = node.parameters?.nodes?.find(p => p?.parameterDefinition?.id === parameterDefinition.id)
-
             const title = parameterDefinition?.names ? parameterDefinition?.names!![0]?.content : parameterDefinition?.id
             const description = parameterDefinition?.descriptions ? parameterDefinition?.descriptions!![0]?.content : JSON.stringify(parameterDefinition?.dataTypeIdentifier)
 

src/packages/ce/src/function/hooks/FunctionSuggestion.hook.tsx

@@ -26,7 +26,7 @@ export const useSuggestions = (
     const node = React.useMemo(() => (flowService.getNodeById(flowId, nodeId)), [flowId, flowStore, nodeId])
     const functionDefinition = React.useMemo(() => (node?.functionDefinition?.id ? functionService.getById(node.functionDefinition.id) : undefined), [functionStore, node?.functionDefinition?.id])
     const parameterDefinition = React.useMemo(() => (functionDefinition?.parameterDefinitions?.find(definition => {
-        const parameterDefinitionId = node?.parameters?.nodes?.[parameterIndex ?? 0]?.parameterDefinition?.id
+        const parameterDefinitionId = node?.parameters?.nodes?.[parameterIndex ?? -1]?.parameterDefinition?.id
         return definition.id === parameterDefinitionId
     })), [functionDefinition?.parameterDefinitions, node])