Skip to content

Commit b96f49b

Browse files
committed
feat: simplify validation filtering logic in FunctionNode components
1 parent 5f17c9f commit b96f49b

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/packages/ce/src/function/components/nodes/FunctionNodeDefaultComponent.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import "./FunctionNodeComponent.style.scss";
44
import {FunctionNodeComponentProps} from "./FunctionNodeComponent";
55
import {Badge, Button, ButtonGroup, Card, Flex, Text, useService, useStore as usePictorStore} from "@code0-tech/pictor";
66
import {useFlowValidation} from "@edition/flow/hooks/Flow.validation.hook";
7-
import {IconBackspace, IconEdit, IconSparkles, IconVariable} from "@tabler/icons-react";
7+
import {IconBackspace, IconCircleX, IconEdit, IconSparkles, IconVariable} from "@tabler/icons-react";
88
import {FlowService} from "@edition/flow/services/Flow.service";
99
import {FunctionService} from "@edition/function/services/Function.service";
1010
import {LiteralBadgeComponent} from "@edition/datatype/components/badges/LiteralBadgeComponent";
@@ -43,7 +43,7 @@ export const FunctionNodeDefaultComponent: React.FC<FunctionNodeDefaultComponent
4343
const validation = useFlowValidation(data.flowId)
4444

4545
const nodeValidations = React.useMemo(
46-
() => validation?.filter(v => v.nodeId === data.nodeId && v.parameterIndex === null && !data.functionId),
46+
() => validation?.filter(v => v.nodeId === data.nodeId && !data.functionId),
4747
[validation]
4848
)
4949

src/packages/ce/src/function/components/nodes/FunctionNodeSquareComponent.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export const FunctionNodeSquareComponent: React.FC<FunctionNodeSquareComponentPr
4040
const validation = useFlowValidation(data.flowId)
4141

4242
const nodeValidations = React.useMemo(
43-
() => validation?.filter(v => v.nodeId === data.nodeId && v.parameterIndex === null && !data.functionId),
43+
() => validation?.filter(v => v.nodeId === data.nodeId && !data.functionId),
4444
[validation]
4545
)
4646

src/packages/ce/src/function/components/nodes/FunctionNodeTriggerComponent.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ export const FunctionNodeTriggerComponent: React.FC<FunctionNodeTriggerComponent
9191
const validation = useFlowValidation(data.flowId)
9292

9393
const triggerValidations = React.useMemo(
94-
() => validation?.filter(v => v.nodeId === null && v.parameterIndex === null),
94+
() => validation?.filter(v => v.nodeId === null),
9595
[validation]
9696
)
9797

0 commit comments

Comments
 (0)