Skip to content

Commit f355b25

Browse files
authored
Merge pull request #254 from code0-tech/feat/#248
Performance problems with Editor within objects
2 parents b5f98b4 + b17b704 commit f355b25

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

src/packages/ce/src/datatype/components/inputs/json/DataTypeJSONInputComponent.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export const DataTypeJSONInputComponent: React.FC<DataTypeJSONInputComponentProp
5757
entry={editEntry}
5858
value={value as LiteralValue}
5959
onOpenChange={open => setEditDialogOpen(open)}
60-
onObjectChange={(value) => {
60+
onObjectClose={(value) => {
6161
formValidation?.setValue?.(value)
6262
onChangeDebounced(value)
6363
}}

src/packages/ce/src/datatype/components/inputs/json/DataTypeJSONInputEditDialogComponent.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ export interface DataTypeJSONInputEditDialogComponentProps {
2626
value: LiteralValue | null
2727
onOpenChange?: (open: boolean) => void
2828
onObjectChange?: (object: LiteralValue | null) => void
29+
onObjectClose?: (object: LiteralValue | null) => void
2930
}
3031

3132
function getValueAtPath(obj: LiteralValue | null, path: string[]): unknown {
@@ -75,6 +76,7 @@ export const DataTypeJSONInputEditDialogComponent: React.FC<DataTypeJSONInputEdi
7576
entry,
7677
value,
7778
onObjectChange,
79+
onObjectClose,
7880
onOpenChange
7981
} = props
8082

@@ -123,7 +125,10 @@ export const DataTypeJSONInputEditDialogComponent: React.FC<DataTypeJSONInputEdi
123125
}
124126

125127
return (
126-
<Dialog open={editOpen} onOpenChange={(open) => onOpenChange?.(open)}>
128+
<Dialog open={editOpen} onOpenChange={(open) => {
129+
onOpenChange?.(open)
130+
if (!open) onObjectClose?.(editedObject)
131+
}}>
127132
<DialogPortal>
128133
<DialogOverlay/>
129134
<DialogContent aria-describedby="DFlowInputObjectEditDialog" onPointerDownOutside={e => {

0 commit comments

Comments
 (0)