ref: cargo clippy

raphael-goetz · raphael-goetz · commit 806fdb7156ed · 2026-06-12T08:44:33.000+02:00
diff --git a/crates/taurus-core/src/runtime/engine/executor.rs b/crates/taurus-core/src/runtime/engine/executor.rs
@@ -734,7 +734,7 @@ impl<'a> EngineExecutor<'a> {
         }
 
         let mut fields = HashMap::new();
-        for (parameter, value) in node.parameters.iter().zip(values.into_iter()) {
+        for (parameter, value) in node.parameters.iter().zip(values) {
             fields.insert(parameter.runtime_parameter_id.clone(), value);
         }
 
diff --git a/crates/taurus-core/src/runtime/functions/http.rs b/crates/taurus-core/src/runtime/functions/http.rs
@@ -297,11 +297,9 @@ fn decode_response_payload(response: http::Response<Body>) -> Result<Value, Stri
             .as_deref()
             .map(content_type_is_json)
             .unwrap_or(false)
-        {
-            if let Ok(json) = serde_json::from_str::<JsonValue>(&text) {
+            && let Ok(json) = serde_json::from_str::<JsonValue>(&text) {
                 return Ok(from_json_value(json));
             }
-        }
 
         return Ok(text.to_value());
     }
diff --git a/crates/taurus-manual/src/main.rs b/crates/taurus-manual/src/main.rs
@@ -164,10 +164,7 @@ async fn main() {
     }
 
     let flow_input = match case.inputs.get(index as usize) {
-        Some(inp) => match inp.input.clone() {
-            Some(json_input) => Some(from_json_value(json_input)),
-            None => None,
-        },
+        Some(inp) => inp.input.clone().map(from_json_value),
         None => None,
     };
 
diff --git a/crates/taurus/src/app/mod.rs b/crates/taurus/src/app/mod.rs
@@ -50,11 +50,10 @@ pub async fn run() {
     wait_for_shutdown(&mut worker_task, &mut health_task).await;
     if let Some(handle) = runtime_status_heartbeat_task.take() {
         handle.abort();
-        if let Err(err) = handle.await {
-            if !err.is_cancelled() {
+        if let Err(err) = handle.await
+            && !err.is_cancelled() {
                 log::warn!("Runtime status heartbeat task ended unexpectedly: {}", err);
             }
-        }
     }
     update_stopped_status(runtime_status_service.as_ref()).await;
 

Original file line number	Diff line number	Diff line change
`@@ -734,7 +734,7 @@ impl<'a> EngineExecutor<'a> {`
`734`	`734`	`}`
`735`	`735`
`736`	`736`	`let mut fields = HashMap::new();`
`737`		`- for (parameter, value) in node.parameters.iter().zip(values.into_iter()) {`
	`737`	`+ for (parameter, value) in node.parameters.iter().zip(values) {`
`738`	`738`	`fields.insert(parameter.runtime_parameter_id.clone(), value);`
`739`	`739`	`}`
`740`	`740`
Original file line number	Diff line number	Diff line change
`@@ -297,11 +297,9 @@ fn decode_response_payload(response: http::Response<Body>) -> Result<Value, Stri`
`297`	`297`	`.as_deref()`
`298`	`298`	`.map(content_type_is_json)`
`299`	`299`	`.unwrap_or(false)`
`300`		`- {`
`301`		`- if let Ok(json) = serde_json::from_str::<JsonValue>(&text) {`
	`300`	`+ && let Ok(json) = serde_json::from_str::<JsonValue>(&text) {`
`302`	`301`	`return Ok(from_json_value(json));`
`303`	`302`	`}`
`304`		`- }`
`305`	`303`
`306`	`304`	`return Ok(text.to_value());`
`307`	`305`	`}`
Original file line number	Diff line number	Diff line change
`@@ -50,11 +50,10 @@ pub async fn run() {`
`50`	`50`	`wait_for_shutdown(&mut worker_task, &mut health_task).await;`
`51`	`51`	`if let Some(handle) = runtime_status_heartbeat_task.take() {`
`52`	`52`	`handle.abort();`
`53`		`- if let Err(err) = handle.await {`
`54`		`- if !err.is_cancelled() {`
	`53`	`+ if let Err(err) = handle.await`
	`54`	`+ && !err.is_cancelled() {`
`55`	`55`	`log::warn!("Runtime status heartbeat task ended unexpectedly: {}", err);`
`56`	`56`	`}`
`57`		`- }`
`58`	`57`	`}`
`59`	`58`	`update_stopped_status(runtime_status_service.as_ref()).await;`
`60`	`59`