feat: improve function suggestion logic and enhance related tests for better type compatibility

Author: nicosammito

src/suggestion/getNodeSuggestions.ts

@@ -15,7 +15,7 @@ export const getNodeSuggestions = (
 
     if (type && functions) {
         function getGenericsCount(input: string): number {
-            const match = input.match(/<([^>]+)>/);
+            const match = input.trim().match(/^<([^>]+)>/);
             if (!match) return 0;
             return match[1].split(',').map(s => s.trim()).filter(Boolean).length;
         }
@@ -30,7 +30,8 @@ export const getNodeSuggestions = (
             `;
         }).join("\n")}
         ${functions?.map((_, i) => `const check${i}: TargetType = {} as F${i};`).join("\n")}
-    `;
+        `;
+
 
         const fileName = "index.ts";
         const host = createCompilerHost(fileName, sourceCode);
@@ -54,7 +55,7 @@ export const getNodeSuggestions = (
     }
 
 
-    return functionToSuggest?.map(f=> {
+    return functionToSuggest?.map(f => {
         return {
             __typename: "NodeFunction",
             id: `gid://sagittarius/NodeFunction/1`,

test/nodeSuggestion.test.ts

@@ -12,13 +12,10 @@ describe("getNodeSuggestions", () => {
 
         expect(map).toEqual(expect.arrayContaining([
             'std::list::first',
-            'std::list::max',
             'std::list::at',
             'std::list::last',
-            'std::list::sum',
             'std::list::pop',
             'std::list::find_last',
-            'std::list::min',
             'std::list::join',
             'std::list::find',
             'std::number::as_text',
@@ -30,24 +27,59 @@ describe("getNodeSuggestions", () => {
             'std::text::reverse',
             'std::text::replace_last',
             'std::text::lowercase',
-            'std::text::to_ascii',
             'std::text::encode',
             'std::text::remove',
             'std::text::swapcase',
             'std::text::append',
             'std::text::insert',
             'std::text::prepend',
-            'std::text::as_bytes',
             'std::text::hex',
             'std::text::replace',
             'std::text::from_ascii',
             'std::text::octal',
-            'std::text::chars',
             'std::text::capitalize',
-            'std::text::split',
             'std::text::replace_first',
             'std::text::uppercase',
             'std::text::at',
+            'std::control::return',
+            'std::control::value'
+        ]))
+
+    });
+
+    it("should suggest functions with compatible return types and prioritize exact matches for boolean", () => {
+
+        // We are looking for suggestions for a 'number' type
+        const suggestions = getNodeSuggestions("BOOLEAN", FUNCTION_SIGNATURES, DATA_TYPES);
+
+        const map = suggestions.map(s => s.functionDefinition?.identifier)
+
+        expect(map).toEqual(expect.arrayContaining([
+            'std::list::first',
+            'std::list::at',
+            'std::list::last',
+            'std::list::pop',
+            'std::list::find_last',
+            'std::list::is_empty',
+            'std::list::find',
+            'std::number::is_zero',
+            'std::number::has_digits',
+            'std::number::is_greater',
+            'std::number::is_equal',
+            'std::number::is_positive',
+            'std::number::is_less',
+            'std::object::contains_key',
+            'std::object::get',
+            'std::object::set',
+            'std::boolean::from_number',
+            'std::boolean::is_equal',
+            'std::boolean::from_text',
+            'std::boolean::negate',
+            'std::text::is_equal',
+            'std::text::ends_with',
+            'std::text::start_with',
+            'std::text::contains',
+            'std::control::return',
             'std::control::value'
         ]))