Skip to content

Commit 1ffef30

Browse files
author
nicosammito
committed
feat: update flow validation test structure for improved clarity and consistency
1 parent 1ef8d0d commit 1ffef30

1 file changed

Lines changed: 146 additions & 104 deletions

File tree

‎test/flowValidation.test.ts‎

Lines changed: 146 additions & 104 deletions
Original file line numberDiff line numberDiff line change
@@ -380,123 +380,165 @@ describe('getFlowValidation - Integrationstest', () => {
380380
"returnType": "HTTP_RESPONSE",
381381
"nodes": {
382382
"__typename": "NodeFunctionConnection",
383-
"nodes": [{
384-
"__typename": "NodeFunction",
385-
"id": "gid://sagittarius/NodeFunction/2",
386-
"nextNodeId": null,
387-
"createdAt": "2026-03-17T14:04:15Z",
388-
"updatedAt": "2026-03-17T19:13:40Z",
389-
"parameters": {
390-
"__typename": "NodeParameterConnection",
391-
"count": 1,
392-
"nodes": [{
393-
"__typename": "NodeParameter",
394-
"id": "gid://sagittarius/NodeParameter/63",
395-
"updatedAt": "2026-03-17T19:13:40Z",
396-
"createdAt": "2026-03-17T18:35:16Z",
397-
"parameterDefinition": {
398-
"__typename": "ParameterDefinition",
399-
"id": "gid://sagittarius/ParameterDefinition/113",
400-
"identifier": "value",
401-
"createdAt": "2026-03-17T14:01:55Z",
402-
"updatedAt": "2026-03-17T14:01:55Z"
403-
},
404-
"value": null
405-
}],
406-
"pageInfo": {"__typename": "PageInfo", "endCursor": "NjM", "hasNextPage": false}
407-
},
408-
"functionDefinition": {
409-
"__typename": "FunctionDefinition",
410-
"id": "gid://sagittarius/FunctionDefinition/74",
411-
"identifier": "std::boolean::from_number"
412-
}
413-
}, {
414-
"__typename": "NodeFunction",
415-
"id": "gid://sagittarius/NodeFunction/3",
416-
"functionDefinition": {
417-
"__typename": "FunctionDefinition",
418-
"id": "gid://sagittarius/FunctionDefinition/7",
419-
"identifier": "std::list::for_each"
383+
"nodes": [
384+
{
385+
"__typename": "NodeFunction",
386+
"id": "gid://sagittarius/NodeFunction/2",
387+
"nextNodeId": null,
388+
"createdAt": "2026-03-17T14:04:15Z",
389+
"updatedAt": "2026-03-17T19:13:40Z",
390+
"parameters": {
391+
"__typename": "NodeParameterConnection",
392+
"count": 1,
393+
"nodes": [
394+
{
395+
"__typename": "NodeParameter",
396+
"id": "gid://sagittarius/NodeParameter/63",
397+
"updatedAt": "2026-03-17T19:13:40Z",
398+
"createdAt": "2026-03-17T18:35:16Z",
399+
"parameterDefinition": {
400+
"__typename": "ParameterDefinition",
401+
"id": "gid://sagittarius/ParameterDefinition/113",
402+
"identifier": "value",
403+
"createdAt": "2026-03-17T14:01:55Z",
404+
"updatedAt": "2026-03-17T14:01:55Z"
405+
},
406+
"value": null
407+
}
408+
],
409+
"pageInfo": {
410+
"__typename": "PageInfo",
411+
"endCursor": "NjM",
412+
"hasNextPage": false
413+
}
414+
},
415+
"functionDefinition": {
416+
"__typename": "FunctionDefinition",
417+
"id": "gid://sagittarius/FunctionDefinition/74",
418+
"identifier": "std::boolean::from_number"
419+
}
420420
},
421-
"parameters": {
422-
"__typename": "NodeParameterConnection",
423-
"nodes": [{
424-
"__typename": "NodeParameter",
425-
"parameterDefinition": {
426-
"__typename": "ParameterDefinition",
427-
"id": "gid://sagittarius/ParameterDefinition/10",
428-
"identifier": "list"
429-
},
430-
"value": null
431-
}, {
432-
"__typename": "NodeParameter",
433-
"parameterDefinition": {
434-
"__typename": "ParameterDefinition",
435-
"id": "gid://sagittarius/ParameterDefinition/11",
436-
"identifier": "consumer"
437-
},
438-
"value": {"id": "gid://sagittarius/NodeFunction/4", "__typename": "NodeFunctionIdWrapper"}
439-
}]
440-
}
441-
}, {
442-
"__typename": "NodeFunction",
443-
"id": "gid://sagittarius/NodeFunction/4",
444-
"functionDefinition": {
445-
"__typename": "FunctionDefinition",
446-
"id": "gid://sagittarius/FunctionDefinition/23",
447-
"identifier": "std::list::join"
421+
{
422+
"__typename": "NodeFunction",
423+
"id": "gid://sagittarius/NodeFunction/3",
424+
"functionDefinition": {
425+
"__typename": "FunctionDefinition",
426+
"id": "gid://sagittarius/FunctionDefinition/75",
427+
"identifier": "std::boolean::is_equal"
428+
},
429+
"parameters": {
430+
"__typename": "NodeParameterConnection",
431+
"nodes": [
432+
{
433+
"__typename": "NodeParameter",
434+
"parameterDefinition": {
435+
"__typename": "ParameterDefinition",
436+
"id": "gid://sagittarius/ParameterDefinition/114",
437+
"identifier": "first"
438+
},
439+
"value": {
440+
"id": "gid://sagittarius/NodeFunction/4",
441+
"__typename": "NodeFunctionIdWrapper"
442+
}
443+
},
444+
{
445+
"__typename": "NodeParameter",
446+
"parameterDefinition": {
447+
"__typename": "ParameterDefinition",
448+
"id": "gid://sagittarius/ParameterDefinition/115",
449+
"identifier": "second"
450+
},
451+
"value": null
452+
}
453+
]
454+
}
448455
},
449-
"parameters": {
450-
"__typename": "NodeParameterConnection",
451-
"nodes": [{
452-
"__typename": "NodeParameter",
453-
"parameterDefinition": {
454-
"__typename": "ParameterDefinition",
455-
"id": "gid://sagittarius/ParameterDefinition/35",
456-
"identifier": "list"
457-
},
458-
"value": null
459-
}, {
460-
"__typename": "NodeParameter",
461-
"parameterDefinition": {
462-
"__typename": "ParameterDefinition",
463-
"id": "gid://sagittarius/ParameterDefinition/36",
464-
"identifier": "join_text"
465-
},
466-
"value": null
467-
}]
456+
{
457+
"__typename": "NodeFunction",
458+
"id": "gid://sagittarius/NodeFunction/4",
459+
"functionDefinition": {
460+
"__typename": "FunctionDefinition",
461+
"id": "gid://sagittarius/FunctionDefinition/68",
462+
"identifier": "std::object::get"
463+
},
464+
"parameters": {
465+
"__typename": "NodeParameterConnection",
466+
"nodes": [
467+
{
468+
"__typename": "NodeParameter",
469+
"parameterDefinition": {
470+
"__typename": "ParameterDefinition",
471+
"id": "gid://sagittarius/ParameterDefinition/99",
472+
"identifier": "object"
473+
},
474+
"value": {
475+
"__typename": "LiteralValue",
476+
"value": {
477+
"test": 1
478+
}
479+
}
480+
},
481+
{
482+
"__typename": "NodeParameter",
483+
"parameterDefinition": {
484+
"__typename": "ParameterDefinition",
485+
"id": "gid://sagittarius/ParameterDefinition/100",
486+
"identifier": "key"
487+
},
488+
"value": null
489+
}
490+
]
491+
}
468492
}
469-
}]
493+
]
494+
},
495+
"project": {
496+
"__typename": "NamespaceProject",
497+
"id": "gid://sagittarius/NamespaceProject/1"
470498
},
471-
"project": {"__typename": "NamespaceProject", "id": "gid://sagittarius/NamespaceProject/1"},
472499
"settings": {
473500
"__typename": "FlowSettingConnection",
474501
"count": 2,
475-
"nodes": [{
476-
"__typename": "FlowSetting",
477-
"id": "gid://sagittarius/FlowSetting/1",
478-
"createdAt": "2026-03-17T14:17:48Z",
479-
"updatedAt": "2026-03-17T14:17:48Z",
480-
"flowSettingIdentifier": "HTTP_METHOD",
481-
"value": ""
482-
}, {
483-
"__typename": "FlowSetting",
484-
"id": "gid://sagittarius/FlowSetting/2",
485-
"createdAt": "2026-03-17T14:17:48Z",
486-
"updatedAt": "2026-03-17T14:17:48Z",
487-
"flowSettingIdentifier": "HTTP_URL",
488-
"value": ""
489-
}],
490-
"pageInfo": {"__typename": "PageInfo", "endCursor": "Mg", "hasNextPage": false}
502+
"nodes": [
503+
{
504+
"__typename": "FlowSetting",
505+
"id": "gid://sagittarius/FlowSetting/1",
506+
"createdAt": "2026-03-17T14:17:48Z",
507+
"updatedAt": "2026-03-17T14:17:48Z",
508+
"flowSettingIdentifier": "HTTP_METHOD",
509+
"value": ""
510+
},
511+
{
512+
"__typename": "FlowSetting",
513+
"id": "gid://sagittarius/FlowSetting/2",
514+
"createdAt": "2026-03-17T14:17:48Z",
515+
"updatedAt": "2026-03-17T14:17:48Z",
516+
"flowSettingIdentifier": "HTTP_URL",
517+
"value": ""
518+
}
519+
],
520+
"pageInfo": {
521+
"__typename": "PageInfo",
522+
"endCursor": "Mg",
523+
"hasNextPage": false
524+
}
491525
},
492526
"startingNodeId": "gid://sagittarius/NodeFunction/3",
493-
"type": {"__typename": "FlowType", "id": "gid://sagittarius/FlowType/1"},
494-
"updatedAt": "2026-03-17T19:18:43Z",
495-
"userAbilities": {"__typename": "FlowUserAbilities", "deleteFlow": true},
527+
"type": {
528+
"__typename": "FlowType",
529+
"id": "gid://sagittarius/FlowType/1"
530+
},
531+
"updatedAt": "2026-03-17T19:56:30Z",
532+
"userAbilities": {
533+
"__typename": "FlowUserAbilities",
534+
"deleteFlow": true
535+
},
496536
};
497537

498538
const result = getFlowValidation(flow, FUNCTION_SIGNATURES, DATA_TYPES);
499539

540+
console.log(result)
541+
500542
expect(result.isValid).toBe(false);
501543
result.diagnostics.forEach((error) => {
502544

0 commit comments

Comments
 (0)