feat: rename inferredType to returnType for consistency across validation functions

Author: nicosammito

src/suggestion/getReferenceSuggestions.ts

@@ -141,7 +141,7 @@ export const getReferenceSuggestions = (
 
         if (isNodeBefore(flow, node, targetNode)) {
             const validation = getNodeValidation(flow, node, functions, dataTypes);
-            suggestions.push(...getValidPaths(validation.inferredType, {
+            suggestions.push(...getValidPaths(validation.returnType, {
                 __typename: "ReferenceValue",
                 nodeFunctionId: node.id,
                 referencePath: []

src/utils.ts

@@ -16,7 +16,7 @@ import {createSystem, createVirtualTypeScriptEnvironment, VirtualTypeScriptEnvir
  */
 export interface ValidationResult {
     isValid: boolean;
-    inferredType: string;
+    returnType: string;
     errors: Array<{
         message: string;
         code: number;
@@ -133,7 +133,7 @@ export function getParameterCode(
 
         if (!refNode) return 'undefined';
 
-        let refType = getNodeValidation(flow, refNode).inferredType;
+        let refType = getNodeValidation(flow, refNode).returnType;
 
         if (refValue.referencePath && refValue.referencePath.length > 0) {
             let refVal: any = undefined;
@@ -168,7 +168,7 @@ export function getParameterCode(
         if (!returnNode) return '(() => undefined)';
 
         const validation = getNodeValidation(flow, returnNode);
-        return `(() => ({} as ${validation.inferredType}))`;
+        return `(() => ({} as ${validation.returnType}))`;
     }
 
     if (value.__typename === "LiteralValue") {

src/validation/getFlowValidation.ts

@@ -130,7 +130,7 @@ export const getFlowValidation = (
 
     return {
         isValid: !errors.some(e => e?.severity === "error"),
-        inferredType: "void",
+        returnType: "void",
         errors,
     };
 };

src/validation/getNodeValidation.ts

@@ -29,7 +29,7 @@ export const getNodeValidation = (
     if (!funcDef) {
         return {
             isValid: false,
-            inferredType: "any",
+            returnType: "any",
             errors: [{message: `Function ${node.id} not found`, code: 404, severity: "error"}],
         };
     }
@@ -55,7 +55,7 @@ export const getNodeValidation = (
     if (scopeErrors.length > 0) {
         return {
             isValid: false,
-            inferredType: "any",
+            returnType: "any",
             errors: scopeErrors,
         };
     }
@@ -120,7 +120,7 @@ export const getNodeValidation = (
 
     return {
         isValid: !errors.some(e => e.severity === "error"),
-        inferredType,
+        returnType: inferredType,
         errors,
     };
 };

src/validation/getValueValidation.ts

@@ -40,7 +40,7 @@ export const getValueValidation = (
 
     return {
         isValid: !errors.some(e => e.severity === "error"),
-        inferredType: "void",
+        returnType: "void",
         errors,
     };
 };

test/nodeValidation.test.ts

@@ -23,7 +23,7 @@ describe('getNodeValidation', () => {
             }
         }, FUNCTION_SIGNATURES, DATA_TYPES);
         expect(result.isValid).toBe(true);
-        expect(result.inferredType).toBeDefined();
+        expect(result.returnType).toBeDefined();
         expect(result.errors.filter(e => e.severity === 'error').length).toBe(0);
     })
 
@@ -87,7 +87,7 @@ describe('getNodeValidation', () => {
 
 
         expect(result.isValid).toBe(true);
-        expect(result.inferredType).toBeDefined();
+        expect(result.returnType).toBeDefined();
         expect(result.errors.filter(e => e.severity === 'error').length).toBe(0);
     })
 
@@ -112,7 +112,7 @@ describe('getNodeValidation', () => {
         }, FUNCTION_SIGNATURES, DATA_TYPES);
 
         expect(result.isValid).toBe(false);
-        expect(result.inferredType).toBeDefined();
+        expect(result.returnType).toBeDefined();
         expect(result.errors.filter(e => e.severity === 'error').length).toBeGreaterThan(0);
     })
 
@@ -179,7 +179,7 @@ describe('getNodeValidation', () => {
         }, FUNCTION_SIGNATURES, DATA_TYPES);
 
         expect(result.isValid).toBe(true);
-        expect(result.inferredType).toBeDefined();
+        expect(result.returnType).toBeDefined();
         expect(result.errors.filter(e => e.severity === 'error').length).toBe(0);
     })
 
@@ -252,7 +252,7 @@ describe('getNodeValidation', () => {
         }, FUNCTION_SIGNATURES, DATA_TYPES);
 
         expect(result.isValid).toBe(true);
-        expect(result.inferredType).toBeDefined();
+        expect(result.returnType).toBeDefined();
         expect(result.errors.filter(e => e.severity === 'error').length).toBe(0);
     })
 
@@ -320,7 +320,7 @@ describe('getNodeValidation', () => {
         }, FUNCTION_SIGNATURES, DATA_TYPES);
 
         expect(result.isValid).toBe(true);
-        expect(result.inferredType).toBeDefined();
+        expect(result.returnType).toBeDefined();
         expect(result.errors.filter(e => e.severity === 'error').length).toBe(0);
     })
 
@@ -363,8 +363,8 @@ describe('getNodeValidation', () => {
         }, FUNCTION_SIGNATURES, DATA_TYPES);
 
         expect(result.isValid).toBe(true);
-        expect(result.inferredType).toBe("number");
-        expect(result.inferredType).toBeDefined();
+        expect(result.returnType).toBe("number");
+        expect(result.returnType).toBeDefined();
         expect(result.errors.filter(e => e.severity === 'error').length).toBe(0);
     })
 
@@ -407,7 +407,7 @@ describe('getNodeValidation', () => {
         }, FUNCTION_SIGNATURES, DATA_TYPES);
 
         expect(result.isValid).toBe(false);
-        expect(result.inferredType).toBeDefined();
+        expect(result.returnType).toBeDefined();
         expect(result.errors.filter(e => e.severity === 'error').length).toBeGreaterThan(0);
     })
 
@@ -450,7 +450,7 @@ describe('getNodeValidation', () => {
         }, FUNCTION_SIGNATURES, DATA_TYPES);
 
         expect(result.isValid).toBe(true);
-        expect(result.inferredType).toBeDefined();
+        expect(result.returnType).toBeDefined();
         expect(result.errors.filter(e => e.severity === 'error').length).toBe(0);
     })
 
@@ -512,7 +512,7 @@ describe('getNodeValidation', () => {
         }, FUNCTION_SIGNATURES, DATA_TYPES);
 
         expect(result.isValid).toBe(true);
-        expect(result.inferredType).toBeDefined();
+        expect(result.returnType).toBeDefined();
         expect(result.errors.filter(e => e.severity === 'error').length).toBe(0);
     })
 
@@ -582,7 +582,7 @@ describe('getNodeValidation', () => {
         }, FUNCTION_SIGNATURES, DATA_TYPES);
 
         expect(result.isValid).toBe(true);
-        expect(result.inferredType).toBeDefined();
+        expect(result.returnType).toBeDefined();
         expect(result.errors.filter(e => e.severity === 'error').length).toBe(0);
     })